payroll_handler_test.go 27 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613
  1. // 课酬试算 + 维护型端点单测(端点 59、61、62、63)——AC-13d 第一批。
  2. //
  3. // 断言纪律同前几批:只断 body 契约,**每个端点至少一条"写错会变红"的断言**,尽量落在库上。
  4. //
  5. // 覆盖:
  6. //
  7. // 59 试算 命中规则 → 9 字段(percentage 是**百分数字符串**不是金额);无方案 → 3112;
  8. // 跨机构 → 1004;日期格式非法 → 2002
  9. // 61 修 max_people 回填后库值 = 分类值;可重跑(第二次 affected=0);分类也 0 的行**不写**
  10. // 62 修 campus_id 单校区课程回填;**多校区课程保持 0**;无规则课程不动
  11. // 63 活动同步 mode=used-log 重建 used_log(DELETE+INSERT);mode=signed 只回写 status>0;
  12. // 非法 mode → 2001;非超管 → 1004
  13. package handler
  14. import (
  15. "strconv"
  16. "strings"
  17. "testing"
  18. "time"
  19. "github.com/gofiber/fiber/v2"
  20. "gorm.io/gorm"
  21. "yuansiwei/unified-backend/internal/academic/apperr"
  22. "yuansiwei/unified-backend/internal/academic/model"
  23. infraerrors "yuansiwei/unified-backend/internal/infra/errors"
  24. appscope "yuansiwei/unified-backend/internal/infra/scope"
  25. )
  26. // newPayrollTestApp 挂 59/61/62/63 四条路由(**不做角色白名单**:白名单由 e2e 验,
  27. // 但 61~63 的"仅超管"还有 Service 层 `assertSuperAdmin` 第二道,本文件**要验第二道**)。
  28. //
  29. // 作用域:`X-Test-Scope: super` 超管;`academic` 教务(非超管,用于验 1004)。
  30. func newPayrollTestApp(t *testing.T, db *gorm.DB) *fiber.App {
  31. t.Helper()
  32. h, err := New(Config{DB: db})
  33. if err != nil {
  34. t.Fatalf("handler.New 失败: %v", err)
  35. }
  36. app := fiber.New(fiber.Config{DisableStartupMessage: true})
  37. app.Use(func(c *fiber.Ctx) error {
  38. switch c.Get("X-Test-Scope") {
  39. case "none":
  40. // 无作用域 → 1001
  41. case "academic":
  42. appscope.Set(c, &appscope.Scope{
  43. InstitutionID: 1, CampusID: 10, UserID: "01HACADEMIC0000000000001", Role: RoleAcademic,
  44. })
  45. default:
  46. appscope.Set(c, testSuperScope())
  47. }
  48. return c.Next()
  49. })
  50. app.Get(PathPayrollPlans, h.ListPayrollPlans)
  51. app.Post(PathPayrollPlans, h.CreatePayrollPlan)
  52. app.Put(PathPayrollPlanDetail, h.UpdatePayrollPlan)
  53. app.Post(PathPayrollQuote, h.QuotePayroll)
  54. app.Post(PathMaintenanceCoursesMaxPeople, h.BackfillCoursesMaxPeople)
  55. app.Post(PathMaintenanceCoursesCampus, h.BackfillCoursesCampus)
  56. app.Post(PathMaintenanceActivitySync, h.SyncActivityData)
  57. return app
  58. }
  59. // ---------------------------------------------------------------- 端点 58:课酬方案
  60. // TestPayrollPlanCreateAndList 端点 58:两级形状(方案 + details)、字段名不与方案撞车、列表回读。
  61. //
  62. // 断言重点(都是 D17 裁决里"命名必须分开"的具体后果):
  63. //
  64. // `schemeName` ≠ 明细 `displayName`:两者在库里都叫 `name`,若实现里同名字段,第二个会覆盖第一个;
  65. // `actived`(方案级)≠ `detailActived`(明细级):两级启用状态必须能看到差异;
  66. // 教龄是**区间两字段** `teacherExpMin/teacherExpMax`,不是单值。
  67. func TestPayrollPlanCreateAndList(t *testing.T) {
  68. db := newCourseTestDB(t)
  69. app := newPayrollTestApp(t, db)
  70. body := map[string]any{
  71. "schemeName": "2026 集体班方案",
  72. "campusId": 10,
  73. "effectDate": "2026-01-01",
  74. "actived": true,
  75. "details": []map[string]any{{
  76. "classType": 1000, "gradeId": -1, "subjectId": -1,
  77. "teacherExpMin": "1.000", "teacherExpMax": "5.000",
  78. "percentage": "85.0", "min": "0.00", "max": "300.00", "reward": "20.00",
  79. "displayName": "集体班-无证档", "detailActived": true,
  80. }, {
  81. "classType": 1000, "gradeId": -1, "subjectId": -1,
  82. "teacherExpMin": "0.000", "teacherExpMax": "0.999",
  83. "percentage": "60.0", "min": "0.00", "max": "0.00", "reward": "0.00",
  84. "displayName": "集体班-新人档", "detailActived": false,
  85. }},
  86. }
  87. code, msg, data := doJSON(t, app, fiber.MethodPost, PathPayrollPlans, body, "X-Test-Token", "t")
  88. if code != 200 {
  89. t.Fatalf("新建课酬方案 = %d(%s),期望 200", code, msg)
  90. }
  91. payload := jsonMap(t, data)
  92. if name, _ := payload["schemeName"].(string); name != "2026 集体班方案" {
  93. t.Fatalf("schemeName = %v,期望 2026 集体班方案(与明细 displayName 分开)", payload["schemeName"])
  94. }
  95. if got, _ := payload["campusId"].(float64); got != 10 {
  96. t.Fatalf("campusId = %v,期望 10", payload["campusId"])
  97. }
  98. planID, _ := payload["id"].(float64)
  99. if planID <= 0 {
  100. t.Fatalf("方案 id = %v,期望 >0", payload["id"])
  101. }
  102. details, _ := payload["details"].([]any)
  103. if len(details) != 2 {
  104. t.Fatalf("details 条数 = %d,期望 2", len(details))
  105. }
  106. first, _ := details[0].(map[string]any)
  107. if name, _ := first["displayName"].(string); name != "集体班-无证档" {
  108. t.Fatalf("明细 displayName = %v,期望 集体班-无证档(被 schemeName 覆盖就是同名字段)", first["displayName"])
  109. }
  110. // ⚠ 教龄区间同样不比较字面量(SQLite 无 DECIMAL:"1.000" 读回是 "1")——比数值,
  111. // 真正要钉住的是"两个界分别下发且各自正确",不是填充位数。
  112. if got := mustDecimal(t, first["teacherExpMin"]); got != 1.0 {
  113. t.Fatalf("teacherExpMin = %v,期望 1.0(区间下界必须单独下发)", first["teacherExpMin"])
  114. }
  115. if got := mustDecimal(t, first["teacherExpMax"]); got != 5.0 {
  116. t.Fatalf("teacherExpMax = %v,期望 5.0(区间上界必须单独下发,否则前端改档会写坏)", first["teacherExpMax"])
  117. }
  118. if got := mustDecimal(t, first["percentage"]); got != 85 {
  119. t.Fatalf("percentage = %v(数值 %v),期望 85(百分数);0.85 说明被当比率、8500 说明被 ×100",
  120. first["percentage"], got)
  121. }
  122. second, _ := details[1].(map[string]any)
  123. if v, _ := second["detailActived"].(bool); v {
  124. t.Fatalf("第二条 detailActived = true,期望 false(明细级启用与方案级 actived 必须能不同)")
  125. }
  126. // 列表:两级形状回读(GET 必须把 details 一并带回,否则前端要 N+1)
  127. code, msg, data = doJSON(t, app, fiber.MethodGet,
  128. PathPayrollPlans+"?institutionId=1&pageSize=10", nil, "X-Test-Token", "t")
  129. if code != 200 {
  130. t.Fatalf("方案列表 = %d(%s),期望 200", code, msg)
  131. }
  132. items := pageList(t, data)
  133. if len(items) != 1 {
  134. t.Fatalf("方案条数 = %d,期望 1", len(items))
  135. }
  136. row, _ := items[0].(map[string]any)
  137. if got, _ := row["id"].(float64); got != planID {
  138. t.Fatalf("列表首行 id = %v,期望 %v", row["id"], planID)
  139. }
  140. listDetails, _ := row["details"].([]any)
  141. if len(listDetails) != 2 {
  142. t.Fatalf("列表行的 details = %d 条,期望 2(列表必须带明细,否则前端要逐行再查)", len(listDetails))
  143. }
  144. }
  145. // TestPayrollPlanUpdateReplacesDetails 端点 58 PUT:`:id` = 方案 id,**明细整体替换**(先删后插)。
  146. //
  147. // 变红条件:
  148. // - 把 `:id` 当明细 id(按明细删改)→ 方案字段改不动 / 明细条数不对;
  149. // - "整体替换"写成"追加" → 明细变 3 条(旧 2 + 新 1)。
  150. func TestPayrollPlanUpdateReplacesDetails(t *testing.T) {
  151. db := newCourseTestDB(t)
  152. app := newPayrollTestApp(t, db)
  153. create := map[string]any{
  154. "schemeName": "替换测试方案", "campusId": 10, "actived": true,
  155. "details": []map[string]any{
  156. {"classType": 1000, "gradeId": -1, "subjectId": -1, "percentage": "80.0", "displayName": "旧档A"},
  157. {"classType": 1000, "gradeId": -1, "subjectId": -1, "percentage": "70.0", "displayName": "旧档B"},
  158. },
  159. }
  160. code, msg, data := doJSON(t, app, fiber.MethodPost, PathPayrollPlans, create, "X-Test-Token", "t")
  161. if code != 200 {
  162. t.Fatalf("建方案 = %d(%s),期望 200", code, msg)
  163. }
  164. planID, _ := jsonMap(t, data)["id"].(float64)
  165. update := map[string]any{
  166. "schemeName": "替换后方案名",
  167. "details": []map[string]any{
  168. {"classType": 1000, "gradeId": -1, "subjectId": -1, "percentage": "90.0", "displayName": "新档"},
  169. },
  170. }
  171. code, msg, data = doJSON(t, app, fiber.MethodPut,
  172. "/admin/payroll/plans/"+itoa(int64(planID)), update, "X-Test-Token", "t")
  173. if code != 200 {
  174. t.Fatalf("更新方案 = %d(%s),期望 200", code, msg)
  175. }
  176. payload := jsonMap(t, data)
  177. if name, _ := payload["schemeName"].(string); name != "替换后方案名" {
  178. t.Fatalf("schemeName = %v,期望 替换后方案名", payload["schemeName"])
  179. }
  180. details, _ := payload["details"].([]any)
  181. if len(details) != 1 {
  182. t.Fatalf("替换后明细 = %d 条,期望 1(整体替换;3 条说明写成了追加)", len(details))
  183. }
  184. only, _ := details[0].(map[string]any)
  185. if name, _ := only["displayName"].(string); name != "新档" {
  186. t.Fatalf("明细 displayName = %v,期望 新档", only["displayName"])
  187. }
  188. // 库里确认旧明细已删(不是只改了响应)
  189. var count int64
  190. db.Model(&model.CoursePaymentDetail{}).Where("course_payment_id = ?", int64(planID)).Count(&count)
  191. if count != 1 {
  192. t.Fatalf("库中明细条数 = %d,期望 1(旧 2 条必须被删掉)", count)
  193. }
  194. }
  195. // TestPayrollPlanValidation 端点 58 的写入校验:比例越界 / 教龄区间倒挂 → 2002。
  196. //
  197. // 两条都是"不报错但规则永不命中/课酬少 100 倍"的静默错法,必须在写入时拒。
  198. func TestPayrollPlanValidation(t *testing.T) {
  199. db := newCourseTestDB(t)
  200. app := newPayrollTestApp(t, db)
  201. base := func(detail map[string]any) map[string]any {
  202. return map[string]any{"schemeName": "校验方案", "campusId": 10, "details": []map[string]any{detail}}
  203. }
  204. cases := []struct {
  205. name string
  206. detail map[string]any
  207. }{
  208. {"比例 > 100(把 0.85 当比率传成 85 反了)", map[string]any{"classType": 1000, "percentage": "850.0"}},
  209. {"比例 2 位小数(列是 decimal(5,1))", map[string]any{"classType": 1000, "percentage": "85.25"}},
  210. {"教龄区间倒挂(规则永不命中)", map[string]any{"classType": 1000, "percentage": "85.0",
  211. "teacherExpMin": "5.000", "teacherExpMax": "1.000"}},
  212. }
  213. for _, tc := range cases {
  214. code, msg, _ := doJSON(t, app, fiber.MethodPost, PathPayrollPlans, base(tc.detail), "X-Test-Token", "t")
  215. if code != infraerrors.ErrBadParam.Code {
  216. t.Errorf("%s = %d(%s),期望 2002", tc.name, code, msg)
  217. }
  218. }
  219. // 对照:合法明细必须 200
  220. ok := base(map[string]any{"classType": 1000, "percentage": "85.0",
  221. "teacherExpMin": "1.000", "teacherExpMax": "2.000"})
  222. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathPayrollPlans, ok, "X-Test-Token", "t"); code != 200 {
  223. t.Fatalf("合法明细 = %d(%s),期望 200", code, msg)
  224. }
  225. }
  226. // ---------------------------------------------------------------- 端点 59:课酬试算
  227. // TestPayrollQuoteReturnsRuleTraceableFields 端点 59 必须回 9 个**可溯源**字段(不能裁掉 4 个溯源字段)。
  228. //
  229. // 变红条件:
  230. // - 漏 `schemeScope`/`ruleTier` → 前端无法定位"命中哪一档",且契约 §4.6 明确不得裁掉;
  231. // - 把 `percentage` 当金额下发("85.0" → "85.00")→ 量纲污染断言红。
  232. func TestPayrollQuoteReturnsRuleTraceableFields(t *testing.T) {
  233. db := newCourseTestDB(t)
  234. classify := seedPayrollClassify(t, db, 1000)
  235. scheme, detail := seedPayrollScheme(t, db, classify.ClassType, "85.0", "0.00", "0.00", "0.00")
  236. app := newPayrollTestApp(t, db)
  237. code, msg, data := doJSON(t, app, fiber.MethodPost, PathPayrollQuote, map[string]any{
  238. "teacherId": courseTestTeacher,
  239. "schoolId": 1,
  240. "campusId": 10,
  241. "classifyId": classify.ID,
  242. "teacherExp": 3.5,
  243. "date": "2026-11-09",
  244. }, "X-Test-Token", "t")
  245. if code != 200 {
  246. t.Fatalf("课酬试算 = %d(%s),期望 200", code, msg)
  247. }
  248. payload := jsonMap(t, data)
  249. if got, _ := payload["detailId"].(float64); got != float64(detail.ID) {
  250. t.Fatalf("detailId = %v,期望 %d", payload["detailId"], detail.ID)
  251. }
  252. if got, _ := payload["schemeId"].(float64); got != float64(scheme.ID) {
  253. t.Fatalf("schemeId = %v,期望 %d", payload["schemeId"], scheme.ID)
  254. }
  255. if got, _ := payload["schemeCampusId"].(float64); got != 10 {
  256. t.Fatalf("schemeCampusId = %v,期望 10(校区级方案)", payload["schemeCampusId"])
  257. }
  258. if got, _ := payload["schemeScope"].(string); got != "campus" {
  259. t.Fatalf("schemeScope = %v,期望 campus(命中校区级方案)", payload["schemeScope"])
  260. }
  261. if got, _ := payload["ruleTier"].(string); got == "" {
  262. t.Fatalf("ruleTier 为空:溯源字段不得裁掉(契约 §4.6 v0.1.29)")
  263. }
  264. // 量纲红线:percentage 是**百分数字符串**,不是金额(不能被 money 格式化)。
  265. // ⚠ 不比较字面量:SQLite 无 DECIMAL 类型,"85.0" 读回来是 "85";生产 MySQL 是 "85.0"。
  266. // 断言"数值等于 85 且**不是 0.85 / 8500**"——这才是"被当 0~1 比率或被 ×100"的真实失败条件。
  267. pctText, _ := payload["percentage"].(string)
  268. pctValue, pctErr := strconv.ParseFloat(strings.TrimSpace(pctText), 64)
  269. if pctErr != nil {
  270. t.Fatalf("percentage = %q 不是合法百分数字符串: %v", pctText, pctErr)
  271. }
  272. if pctValue != 85 {
  273. t.Fatalf("percentage = %q(数值 %v),期望 85(百分数);0.85 说明被当比率、8500 说明被 ×100",
  274. pctText, pctValue)
  275. }
  276. if got, _ := payload["min"].(string); got != "0.00" {
  277. t.Fatalf("min = %v,期望 \"0.00\"", payload["min"])
  278. }
  279. }
  280. // TestPayrollQuoteErrors 端点 59 的错误分流:无方案 → 3112;跨机构 → 1004;日期非法 → 2002。
  281. func TestPayrollQuoteErrors(t *testing.T) {
  282. db := newCourseTestDB(t)
  283. classify := seedPayrollClassify(t, db, 1000) // 只建分类,**不建方案**
  284. app := newPayrollTestApp(t, db)
  285. base := map[string]any{
  286. "teacherId": courseTestTeacher, "schoolId": 1, "campusId": 10,
  287. "classifyId": classify.ID, "teacherExp": 1, "date": "2026-11-09",
  288. }
  289. // 无方案 → 3112(结课侧会把它降级为 0 课酬,但试算入口必须暴露)
  290. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathPayrollQuote, base, "X-Test-Token", "t"); code != apperr.CodePayrollPlanMissing {
  291. t.Fatalf("无方案试算 = %d(%s),期望 3112", code, msg)
  292. }
  293. // 跨机构(作用域机构 1,传入 2)→ 1004。
  294. // **必须用非超管作用域**:超管按设计可查任意机构(`assertInstitution` 放行),
  295. // 用超管测 1004 会得到 3112(无方案),把"越权没拦"误判成"业务错"。
  296. cross := map[string]any{
  297. "teacherId": courseTestTeacher, "schoolId": 2, "campusId": 10,
  298. "classifyId": classify.ID, "teacherExp": 1, "date": "2026-11-09",
  299. }
  300. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathPayrollQuote, cross,
  301. "X-Test-Token", "t", "X-Test-Scope", "academic"); code != infraerrors.ErrUnscoped.Code {
  302. t.Fatalf("跨机构试算 = %d(%s),期望 1004", code, msg)
  303. }
  304. // 日期格式非法 → 2002
  305. bad := map[string]any{
  306. "teacherId": courseTestTeacher, "schoolId": 1, "campusId": 10,
  307. "classifyId": classify.ID, "teacherExp": 1, "date": "2026/11/09",
  308. }
  309. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathPayrollQuote, bad, "X-Test-Token", "t"); code != infraerrors.ErrBadFormat.Code {
  310. t.Fatalf("非法日期 = %d(%s),期望 2002", code, msg)
  311. }
  312. }
  313. // seedPayrollClassify 建课程分类(class_type 决定课酬规则维度)。
  314. func seedPayrollClassify(t *testing.T, db *gorm.DB, classType int32) *model.CoursesClassify {
  315. t.Helper()
  316. row := &model.CoursesClassify{
  317. InstitutionID: 1, CampusID: 10, ClassType: classType, GradeID: 0, SubjectID: 0,
  318. Name: "课酬测试班", UnitPrice: "100.00", MinPeople: 1, MaxPeople: 10,
  319. }
  320. if err := db.Create(row).Error; err != nil {
  321. t.Fatalf("建分类失败: %v", err)
  322. }
  323. return row
  324. }
  325. // seedPayrollScheme 建一套"校区级方案 + 无证通用规则"(命中确定,便于逐字段断言)。
  326. func seedPayrollScheme(t *testing.T, db *gorm.DB, classType int32, percentage, minPayment, maxPayment, reward string) (*model.CoursePayment, *model.CoursePaymentDetail) {
  327. t.Helper()
  328. effect := time.Now().AddDate(0, 0, -30)
  329. scheme := &model.CoursePayment{
  330. InstitutionID: 1, CampusID: 10, Actived: true, EffectDate: &effect,
  331. }
  332. if err := db.Create(scheme).Error; err != nil {
  333. t.Fatalf("建课酬方案失败: %v", err)
  334. }
  335. detail := &model.CoursePaymentDetail{
  336. CoursePaymentID: scheme.ID, GradeID: -1, SubjectID: -1, ClassType: classType, ClassifyID: 0,
  337. Percentage: percentage, MinPayment: minPayment, MaxPayment: maxPayment, Reward: reward,
  338. TeacherCert: false, TeacherExpMin: "0.000", TeacherExpMax: "100.000", Actived: true,
  339. }
  340. if err := db.Create(detail).Error; err != nil {
  341. t.Fatalf("建课酬规则失败: %v", err)
  342. }
  343. return scheme, detail
  344. }
  345. // ---------------------------------------------------------------- 端点 61:修 max_people
  346. // TestBackfillMaxPeopleIdempotent 端点 61:按分类回填 + 分类未配置的行**不写 0** + 可重跑。
  347. //
  348. // 变红条件:
  349. // - 分类未配置(max_people=0)的课程被写成 0 → 该断言行"必须保持 NULL/0 且计入 skipped"红;
  350. // - 第二次执行 affected≠0 → 幂等红。
  351. func TestBackfillMaxPeopleIdempotent(t *testing.T) {
  352. db := newCourseTestDB(t)
  353. // 分类 A:max_people=25;分类 B:max_people=0(未配置)
  354. classifyA := seedPayrollClassify(t, db, 1000)
  355. classifyA.MaxPeople = 25
  356. if err := db.Save(classifyA).Error; err != nil {
  357. t.Fatalf("更新分类失败: %v", err)
  358. }
  359. classifyB := seedPayrollClassify(t, db, 1001) // MaxPeople 默认 1000 → 显式压成 0
  360. if err := db.Model(&model.CoursesClassify{}).Where("id = ?", classifyB.ID).
  361. UpdateColumn("max_people", 0).Error; err != nil {
  362. t.Fatalf("压零分类 B 失败: %v", err)
  363. }
  364. courseA := seedCourse(t, db, "待回填A", 10)
  365. courseA.ClassifyID = classifyA.ID
  366. db.Save(courseA)
  367. courseB := seedCourse(t, db, "分类未配置B", 10)
  368. courseB.ClassifyID = classifyB.ID
  369. db.Save(courseB)
  370. app := newPayrollTestApp(t, db)
  371. code, msg, data := doJSON(t, app, fiber.MethodPost, PathMaintenanceCoursesMaxPeople, nil, "X-Test-Token", "t")
  372. if code != 200 {
  373. t.Fatalf("修 max_people = %d(%s),期望 200", code, msg)
  374. }
  375. if got, _ := jsonMap(t, data)["affected"].(float64); got != 1 {
  376. t.Fatalf("affected = %v,期望 1(只有 A 被回填;分类为 0 的行不得写 0)", jsonMap(t, data)["affected"])
  377. }
  378. var gotA, gotB int32
  379. db.Raw("SELECT max_people FROM t_courses WHERE id = ?", courseA.ID).Scan(&gotA)
  380. db.Raw("SELECT max_people FROM t_courses WHERE id = ?", courseB.ID).Scan(&gotB)
  381. if gotA != 25 {
  382. t.Fatalf("课程 A max_people = %d,期望 25(继承分类)", gotA)
  383. }
  384. if gotB != 0 {
  385. t.Fatalf("课程 B max_people = %d,期望 0(分类未配置,不得写别的值)", gotB)
  386. }
  387. // 可重跑:第二次 affected = 0
  388. code, msg, data = doJSON(t, app, fiber.MethodPost, PathMaintenanceCoursesMaxPeople, nil, "X-Test-Token", "t")
  389. if code != 200 {
  390. t.Fatalf("二次修 max_people = %d(%s),期望 200", code, msg)
  391. }
  392. if got, _ := jsonMap(t, data)["affected"].(float64); got != 0 {
  393. t.Fatalf("二次 affected = %v,期望 0(幂等)", jsonMap(t, data)["affected"])
  394. }
  395. }
  396. // ---------------------------------------------------------------- 端点 62:修 campus_id
  397. // TestBackfillCoursesCampusSkipsMultiCampus 端点 62:**多校区课程必须保持 0**(机构级),单校区回填。
  398. //
  399. // 变红条件:把多校区课程也回填 → 课程被锁进某一个校区、其它校区看不到(越权/丢数据);
  400. //
  401. // 无排班规则的课程被回填(0≠1)→ affected 变 2。
  402. func TestBackfillCoursesCampusSkipsMultiCampus(t *testing.T) {
  403. db := newCourseTestDB(t)
  404. single := seedCourse(t, db, "单校区课", 0) // campus_id=0 待回填
  405. multi := seedCourse(t, db, "多校区课", 0) // 两条规则、两个校区 → 保持 0
  406. noRule := seedCourse(t, db, "无规则课", 0) // 无规则 → 不回填
  407. // 单校区:1 条规则(campus 10)
  408. seedClassRule(t, db, single.ID, 9101, courseTestTeacher, "1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  409. // 多校区:2 条规则,其中一条改到 campus 20
  410. seedClassRule(t, db, multi.ID, 9201, courseTestTeacher, "1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  411. otherCampus := seedClassRule(t, db, multi.ID, 9201, courseTestTeacher, "3", model.CoursesClassStatusOngoing, "11:00", "12:00")
  412. otherCampus.CampusID = 20
  413. if err := db.Save(otherCampus).Error; err != nil {
  414. t.Fatalf("改规则校区失败: %v", err)
  415. }
  416. app := newPayrollTestApp(t, db)
  417. code, msg, data := doJSON(t, app, fiber.MethodPost, PathMaintenanceCoursesCampus, nil, "X-Test-Token", "t")
  418. if code != 200 {
  419. t.Fatalf("修 campus_id = %d(%s),期望 200", code, msg)
  420. }
  421. if got, _ := jsonMap(t, data)["affected"].(float64); got != 1 {
  422. t.Fatalf("affected = %v,期望 1(只有单校区课程被回填)", jsonMap(t, data)["affected"])
  423. }
  424. var gotSingle, gotMulti, gotNoRule int64
  425. db.Raw("SELECT campus_id FROM t_courses WHERE id = ?", single.ID).Scan(&gotSingle)
  426. db.Raw("SELECT campus_id FROM t_courses WHERE id = ?", multi.ID).Scan(&gotMulti)
  427. db.Raw("SELECT campus_id FROM t_courses WHERE id = ?", noRule.ID).Scan(&gotNoRule)
  428. if gotSingle != 10 {
  429. t.Fatalf("单校区课程 campus_id = %d,期望 10", gotSingle)
  430. }
  431. if gotMulti != 0 {
  432. t.Fatalf("多校区课程 campus_id = %d,期望 0(机构级课程不得被锁进单校区)", gotMulti)
  433. }
  434. if gotNoRule != 0 {
  435. t.Fatalf("无规则课程 campus_id = %d,期望 0(计数 0 ≠ 1,不回填)", gotNoRule)
  436. }
  437. }
  438. // ---------------------------------------------------------------- 端点 63:活动数据同步
  439. // TestActivitySyncModes 端点 63:两种 mode 各走各的 SP;非法 mode → 2001;非超管 → 1004。
  440. //
  441. // 变红条件:
  442. // - 非法 mode 落进某个分支(会被当成 used-log 而清表!)→ 2001 断言红;
  443. // - mode=signed 把已取消报名(status=0)的行走回写 → 数据断言红。
  444. func TestActivitySyncModes(t *testing.T) {
  445. db := newCourseTestDB(t)
  446. // ---- used-log 模式:造 1 条 discount_log,重建后 used_log 应有 1 行
  447. activity := &model.CoursesActivity{
  448. InstitutionID: 1, CampusID: 10, Type: 2, Title: ptr("充值赠送活动"), Status: 1,
  449. Money: "100.00",
  450. }
  451. if err := db.Create(activity).Error; err != nil {
  452. t.Fatalf("建活动失败: %v", err)
  453. }
  454. const studentID = courseTestStudent
  455. // SP30 的数据形状:**流水只指向池行**(`t_courses_activity_user_discount_log` 没有
  456. // activity_id/user_id 列)⇒ 必须"池行 + 流水行"两条,重建才能 JOIN 出 activity/user。
  457. pool := &model.CoursesActivityUserDiscount{
  458. ActivityID: activity.ID, InstitutionID: 1, CampusID: 10, UserID: studentID,
  459. Income: "100.00", DiscountAmount: "100.00", DiscountAmountUsed: "50.00",
  460. }
  461. if err := db.Create(pool).Error; err != nil {
  462. t.Fatalf("建赠送池行失败: %v", err)
  463. }
  464. logRow := &model.CoursesActivityUserDiscountLog{
  465. ActivityUserDiscountID: pool.ID,
  466. DiscountAmountUsed: "-50.00", Memo: ptr("使用赠送"),
  467. }
  468. if err := db.Create(logRow).Error; err != nil {
  469. t.Fatalf("建赠送流水失败: %v", err)
  470. }
  471. app := newPayrollTestApp(t, db)
  472. code, msg, data := doJSON(t, app, fiber.MethodPost, PathMaintenanceActivitySync,
  473. map[string]any{"mode": "used-log"}, "X-Test-Token", "t")
  474. if code != 200 {
  475. t.Fatalf("used-log 同步 = %d(%s),期望 200", code, msg)
  476. }
  477. if got, _ := jsonMap(t, data)["affected"].(float64); got != 1 {
  478. t.Fatalf("used-log affected = %v,期望 1(重建出 1 行)", jsonMap(t, data)["affected"])
  479. }
  480. var usedCount int64
  481. db.Model(&model.CoursesActivityUsedLog{}).Count(&usedCount)
  482. if usedCount != 1 {
  483. t.Fatalf("used_log 行数 = %d,期望 1", usedCount)
  484. }
  485. // ---- signed 模式:status=0(已取消)的行不得被历史工单"复活"
  486. signed := &model.CoursesActivitySigned{
  487. ActivityID: activity.ID, UserID: studentID, Status: 0, RechargeAmount: "0.00",
  488. }
  489. if err := db.Create(signed).Error; err != nil {
  490. t.Fatalf("建报名行失败: %v", err)
  491. }
  492. request := &model.UserBalanceRequest{
  493. BizNo: "REQ-SYNC-1", InstitutionID: 1, CampusID: 10, UserID: studentID,
  494. Type: 100, Money: "100.00", Approved: 1,
  495. }
  496. if err := db.Create(request).Error; err != nil {
  497. t.Fatalf("建充值工单失败: %v", err)
  498. }
  499. pool2 := &model.CoursesActivityUserDiscount{
  500. ActivityID: activity.ID, InstitutionID: 1, CampusID: 10, UserID: studentID,
  501. BalanceRequestID: &request.ID, Income: "100.00", DiscountAmount: "100.00",
  502. }
  503. if err := db.Create(pool2).Error; err != nil {
  504. t.Fatalf("建第二池行失败: %v", err)
  505. }
  506. code, msg, _ = doJSON(t, app, fiber.MethodPost, PathMaintenanceActivitySync,
  507. map[string]any{"mode": "signed"}, "X-Test-Token", "t")
  508. if code != 200 {
  509. t.Fatalf("signed 同步 = %d(%s),期望 200", code, msg)
  510. }
  511. var signedStatus int8
  512. db.Raw("SELECT status FROM t_courses_activity_signed WHERE id = ?", signed.ID).Scan(&signedStatus)
  513. if signedStatus != 0 {
  514. t.Fatalf("已取消报名的 status = %d,期望仍为 0(重放不得复活已取消报名)", signedStatus)
  515. }
  516. // ---- 非法 / 缺失 mode → 2001(**绝不能落进任何分支**:落进 used-log 会清表)
  517. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathMaintenanceActivitySync,
  518. map[string]any{"mode": "drop-all"}, "X-Test-Token", "t"); code != infraerrors.ErrBadFormat.Code {
  519. t.Fatalf("非法 mode = %d(%s),期望 2002", code, msg)
  520. }
  521. // 缺失 mode → **2001**(未提供必要参数);传了非法值 → **2002**(枚举越界,与端点 25 一致)
  522. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathMaintenanceActivitySync,
  523. map[string]any{}, "X-Test-Token", "t"); code != infraerrors.ErrBadParam.Code {
  524. t.Fatalf("缺失 mode = %d(%s),期望 2001", code, msg)
  525. }
  526. // 非法 mode 之后 used_log 必须还在(证明没有误清表)
  527. db.Model(&model.CoursesActivityUsedLog{}).Count(&usedCount)
  528. if usedCount != 1 {
  529. t.Fatalf("非法 mode 后 used_log 行数 = %d,期望仍为 1(**误清表**)", usedCount)
  530. }
  531. }
  532. // TestMaintenanceRequiresSuperAdmin 61~63 的**第二道防线**:非超管即使绕过路由白名单也要 1004。
  533. //
  534. // 为什么必须测第二道:路由白名单和种子是**配置**,配错只会让"该拦的没拦";
  535. // Service 层 `assertSuperAdmin` 是代码里的硬断言,两者独立,缺一不可。
  536. func TestMaintenanceRequiresSuperAdmin(t *testing.T) {
  537. db := newCourseTestDB(t)
  538. app := newPayrollTestApp(t, db)
  539. cases := []struct {
  540. name string
  541. path string
  542. body any
  543. }{
  544. {"61 修 max_people", PathMaintenanceCoursesMaxPeople, nil},
  545. {"62 修 campus", PathMaintenanceCoursesCampus, nil},
  546. {"63 活动同步", PathMaintenanceActivitySync, map[string]any{"mode": "used-log"}},
  547. }
  548. for _, tc := range cases {
  549. code, msg, _ := doJSON(t, app, fiber.MethodPost, tc.path, tc.body,
  550. "X-Test-Token", "t", "X-Test-Scope", "academic")
  551. if code != infraerrors.ErrUnscoped.Code {
  552. t.Errorf("%s 非超管 = %d(%s),期望 1004(Service 层 assertSuperAdmin)", tc.name, code, msg)
  553. }
  554. }
  555. // 对照:超管通过(61 在空库上 affected=0,不是 1004)
  556. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathMaintenanceCoursesMaxPeople, nil,
  557. "X-Test-Token", "t"); code != 200 {
  558. t.Errorf("61 超管 = %d(%s),期望 200", code, msg)
  559. }
  560. }
  561. // ptr 返回字符串指针(测试夹具的可空列用)。
  562. func ptr(v string) *string { return &v }
  563. // mustDecimal 把 JSON 里的数值字段(字符串或数字)转 float(不比较字面量填充位数)。
  564. //
  565. // 为什么需要:SQLite 没有 DECIMAL 类型,`"1.000"` 读回来是 `"1"`;生产 MySQL 是 `"1.000"`。
  566. // 断言要跨方言成立,只能比数值。
  567. func mustDecimal(t *testing.T, v any) float64 {
  568. t.Helper()
  569. switch value := v.(type) {
  570. case string:
  571. parsed, err := strconv.ParseFloat(strings.TrimSpace(value), 64)
  572. if err != nil {
  573. t.Fatalf("%v 不是合法数值: %v", v, err)
  574. }
  575. return parsed
  576. case float64:
  577. return value
  578. default:
  579. t.Fatalf("%v 既不是字符串也不是数字(%T)", v, v)
  580. return 0
  581. }
  582. }