course_handler_test.go 68 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543
  1. // 课程 / 排班 / 打卡端点单测(AC-13c:端点 44~57)。
  2. //
  3. // 断言纪律(与前几批一致):
  4. // - 只断 body 契约(HTTP 恒 200 + body.code),不断 HTTP 状态码;
  5. // - **每个端点至少一条"写错会变红"的断言**,且尽量落在**数据库**上而不是只断响应体
  6. // (响应体可以"改一个字段名"骗过自己,库里的列不会);
  7. // - 错误码只比对 `apperr` / `infraerrors` 的常量,**不硬编码数字**。
  8. //
  9. // 覆盖结构:
  10. //
  11. // 44 课程列表 teacherIds 来自 t_courses_class、recordCount 来自 t_courses_record;
  12. // 跨机构课程**不出现**(Scoped)
  13. // 45 新建/更新课程 新建恒 status=0(未发布);PUT 是部分更新(未传字段不变)
  14. // 46 排班规则 status=2(已结束)的规则**必须出现**(onlyActive 会漏);week 原值
  15. // 47 新建规则 同老师+同周+时段重叠 → **3122**;不同周 → 200
  16. // 49 生成课表 幂等:第二次 generated=0 / changed=false
  17. // 50 开始上课 actual_start_time 落库;重复开始 → **3121**
  18. // 51 结束上课 跨 5 张表断言(record_student / expense / expense_school / divide_log / payroll)
  19. // + 分账失败整体回滚(变异)
  20. // 52 打卡 已结束的课 → **3121**;未结束 → 写 cost 并回显 checked
  21. // 53 报课学生 欠费字段取 remainder_receivable(造 unpaid=999 的陷阱行)
  22. // 54 报名 快照恒等式 receivable = net_receipts + remainder_receivable;
  23. // confirm_discount_user_id 必须写(否则永远进不了核销候选);重复 → 3140
  24. // 55 欠费列表 **remainder_receivable > 0**(造 unpaid=999/remainder=0 的陷阱行必须不出现)
  25. // 56 欠费核销 net_receipts 增、remainder_receivable 减(同一条 UPDATE);跨机构 → 1004
  26. // 57 学生课表 按学生过滤(另一个学生的课不出现);跨用户查 → 1004
  27. package handler
  28. import (
  29. "context"
  30. "encoding/json"
  31. "errors"
  32. "strings"
  33. "testing"
  34. "time"
  35. "github.com/gofiber/fiber/v2"
  36. "gorm.io/gorm"
  37. "yuansiwei/unified-backend/internal/academic/apperr"
  38. "yuansiwei/unified-backend/internal/academic/model"
  39. "yuansiwei/unified-backend/internal/academic/money"
  40. "yuansiwei/unified-backend/internal/academic/port"
  41. infraerrors "yuansiwei/unified-backend/internal/infra/errors"
  42. appscope "yuansiwei/unified-backend/internal/infra/scope"
  43. )
  44. // ---------------------------------------------------------------- 测试基础设施
  45. // 测试用常量(ULID 形态的假 ID,长度 26 与真实约束一致)。
  46. const (
  47. courseTestStudent = "01HSTUDENT00000000000001"
  48. courseTestOther = "01HSTUDENT00000000000002"
  49. courseTestTeacher = "01HTEACHER00000000000001"
  50. courseTestTeacher2 = "01HTEACHER00000000000002"
  51. courseTestRecommender = "01HRECOMMENDER00000000001"
  52. courseTestUpline = "01HUPLINE00000000000001"
  53. courseTestOperator = "01HOPERATOR0000000000001"
  54. )
  55. // newCourseTestDB 课程域测试库:资金四表(复用)+ 课程 6 表 + 课酬 3 表 + 分账 2 表。
  56. //
  57. // 与 `newHandlerTestDB` 同构地逐表 AutoMigrate 并删除**非唯一索引**(SQLite 索引名库级唯一,
  58. // 而 academic model 多表共用 `idx_inst_campus` 等名字)。
  59. func newCourseTestDB(t *testing.T) *gorm.DB {
  60. t.Helper()
  61. base := newHandlerTestDB(t) // 资金 4 表 + 活动 6 表 + t_campus(机构 1 / 校区 10)
  62. extra := []any{
  63. &model.Courses{}, &model.CoursesClassify{}, &model.CoursesClass{},
  64. &model.CoursesStudent{}, &model.CoursesRecord{}, &model.CoursesRecordStudent{},
  65. &model.CoursePayment{}, &model.CoursePaymentDetail{}, &model.TeacherInformation{},
  66. &model.UserDivideInto{}, &model.UserDivideIntoLog{},
  67. }
  68. // 先把 `newHandlerTestDB` 留下的**唯一索引**清干净:`uk_biz_no` 在 t_user_balance_request
  69. // (资金域)与 3 张课程表上同名,SQLite 的索引名是库级唯一 ⇒ 不清会直接建表失败。
  70. // 测试库放弃唯一约束(生产 MySQL 表级隔离,不受影响)。
  71. var leftovers []string
  72. if err := base.Raw(
  73. "SELECT name FROM sqlite_master WHERE type='index' AND name NOT LIKE 'sqlite_%'").Scan(&leftovers).Error; err != nil {
  74. t.Fatalf("读取遗留索引失败: %v", err)
  75. }
  76. for _, name := range leftovers {
  77. if err := base.Exec("DROP INDEX IF EXISTS `" + name + "`").Error; err != nil {
  78. t.Fatalf("删除遗留索引(%s) 失败: %v", name, err)
  79. }
  80. }
  81. for _, tbl := range extra {
  82. if err := base.AutoMigrate(tbl); err != nil {
  83. t.Fatalf("AutoMigrate(%T) 失败: %v", tbl, err)
  84. }
  85. stmt := &gorm.Statement{DB: base}
  86. if err := stmt.Parse(tbl); err != nil {
  87. t.Fatalf("解析表名(%T) 失败: %v", tbl, err)
  88. }
  89. var idxRows []struct {
  90. Name string
  91. SQL *string
  92. }
  93. if err := base.Raw(
  94. "SELECT name, sql FROM sqlite_master WHERE type='index' AND tbl_name=? AND name NOT LIKE 'sqlite_%'",
  95. stmt.Schema.Table).Scan(&idxRows).Error; err != nil {
  96. t.Fatalf("读索引清单(%s) 失败: %v", stmt.Schema.Table, err)
  97. }
  98. for _, row := range idxRows {
  99. // ⚠ **唯一索引也一并删除**(与 `newHandlerTestDB` 不同):academic model 里
  100. // `uk_biz_no` 同时出现在 t_courses_student / t_courses_record / t_courses_record_student
  101. // 三张表上,而 SQLite 的索引名是**库级唯一**(MySQL 是表级)⇒ 第二张表建索引必报
  102. // "index uk_biz_no already exists"。测试库因此放弃唯一约束(生产是 MySQL,不受影响;
  103. // 服务层测试 `migrateLearningTables` 同款处理)。
  104. if err := base.Exec("DROP INDEX IF EXISTS `" + row.Name + "`").Error; err != nil {
  105. t.Fatalf("删索引(%s) 失败: %v", row.Name, err)
  106. }
  107. }
  108. }
  109. return base
  110. }
  111. // newCourseTestApp 挂 15 条课程域路由(**不做角色白名单**:那是 e2e 的职责,见 route_e2e_test.go)。
  112. //
  113. // 作用域由 `X-Test-Scope` 头选择:`none` = 不注入(1001)、`super` = 超管、`student` = 学生、
  114. // `teacher` = 老师、缺省 = 财务(机构 1 / 校区 10)。
  115. func newCourseTestApp(t *testing.T, db *gorm.DB) *fiber.App {
  116. t.Helper()
  117. return newCourseTestAppWithUsers(t, db, nil)
  118. }
  119. // newCourseTestAppWithUsers 同 `newCourseTestApp`,但可注入用户姓名端口(D4 用)。
  120. //
  121. // 入参:users `port.UserNameReader`(nil = 未注入,端点 53 的 realName 应全部为 null)。
  122. func newCourseTestAppWithUsers(t *testing.T, db *gorm.DB, users port.UserNameReader) *fiber.App {
  123. t.Helper()
  124. h, err := New(Config{DB: db, Users: users})
  125. if err != nil {
  126. t.Fatalf("handler.New 失败: %v", err)
  127. }
  128. app := fiber.New(fiber.Config{DisableStartupMessage: true})
  129. app.Use(func(c *fiber.Ctx) error {
  130. switch c.Get("X-Test-Scope") {
  131. case "none":
  132. // 不写作用域 → 未登录语义(1001)
  133. case "super":
  134. appscope.Set(c, testSuperScope())
  135. case "student":
  136. appscope.Set(c, &appscope.Scope{
  137. InstitutionID: 1, CampusID: 10,
  138. UserID: courseTestStudent, Role: RoleStudent,
  139. })
  140. case "teacher":
  141. appscope.Set(c, &appscope.Scope{
  142. InstitutionID: 1, CampusID: 10,
  143. UserID: courseTestTeacher, Role: RoleTeacher,
  144. })
  145. default:
  146. appscope.Set(c, testScope())
  147. }
  148. return c.Next()
  149. })
  150. // 注册顺序与 route.go 一致(静态段先于 `:id`)
  151. app.Get(PathCourses, h.ListCourses)
  152. app.Post(PathCourses, h.CreateCourse)
  153. app.Get(PathCourseArrears, h.ListCourseArrears)
  154. app.Post(PathCourseArrearsCounteract, h.CounteractCourseArrears)
  155. app.Post(PathCourseRecordStart, h.StartCourseRecord)
  156. app.Post(PathCourseRecordFinish, h.FinishCourseRecord)
  157. app.Post(PathCourseRecordAttendance, h.MarkCourseRecordAttendance)
  158. app.Put(PathCourseDetail, h.UpdateCourse)
  159. app.Get(PathCourseClasses, h.ListCourseClasses)
  160. app.Post(PathCourseClasses, h.CreateCourseClass)
  161. app.Get(PathCourseRecords, h.ListCourseRecords)
  162. app.Post(PathCourseRecordsGenerate, h.GenerateCourseRecords)
  163. app.Get(PathCourseStudents, h.ListCourseStudents)
  164. app.Post(PathCourseStudents, h.EnrollCourseStudent)
  165. app.Get(PathStudentSchedule, h.GetStudentSchedule)
  166. return app
  167. }
  168. // seedCourse 建一门课程(机构 1 / 指定校区;classify 默认 0)。
  169. func seedCourse(t *testing.T, db *gorm.DB, name string, campusID int64) *model.Courses {
  170. t.Helper()
  171. row := &model.Courses{
  172. InstitutionID: 1, CampusID: campusID, Name: name,
  173. Status: model.CoursesStatusUnpublished, Number: 10, Duration: "1.0", Week: "-1",
  174. OriginalCost: "100.00", RealPrice: "100.00", DiscountCash: "0.00",
  175. }
  176. if err := db.Create(row).Error; err != nil {
  177. t.Fatalf("建课程失败: %v", err)
  178. }
  179. return row
  180. }
  181. // seedClassRule 建一条排班规则。
  182. func seedClassRule(t *testing.T, db *gorm.DB, coursesID, classID int64, teacher, week string, status int32, startHM, endHM string) *model.CoursesClass {
  183. t.Helper()
  184. start := mustHM(t, startHM)
  185. var end *time.Time
  186. if endHM != "" {
  187. end = mustHM(t, endHM)
  188. }
  189. row := &model.CoursesClass{
  190. Status: status, CoursesID: coursesID, ClassID: classID,
  191. TeacherID: &teacher, InstitutionID: 1, CampusID: 10,
  192. StandardLessonCost: "100.00", Number: 10, LessonCost: "100.00",
  193. DiscountCash: "0.00", FinishedNumber: 0, Confirm: model.CoursesClassConfirmNo,
  194. Week: week, StartTime: start, EndTime: end,
  195. }
  196. if err := db.Create(row).Error; err != nil {
  197. t.Fatalf("建排班规则失败: %v", err)
  198. }
  199. return row
  200. }
  201. // mustHM 把 "HH:MM" 转成时分列(1970-01-01 + 时分,UTC),与服务层口径一致。
  202. func mustHM(t *testing.T, hm string) *time.Time {
  203. t.Helper()
  204. parts := strings.Split(hm, ":")
  205. hour := mustAtoi(t, parts[0])
  206. minute := 0
  207. if len(parts) > 1 {
  208. minute = mustAtoi(t, parts[1])
  209. }
  210. at := time.Date(1970, 1, 1, hour, minute, 0, 0, time.UTC)
  211. return &at
  212. }
  213. // mustAtoi 测试用 Atoi(失败即 fatal)。
  214. func mustAtoi(t *testing.T, raw string) int {
  215. t.Helper()
  216. value := 0
  217. for _, ch := range strings.TrimSpace(raw) {
  218. if ch < '0' || ch > '9' {
  219. t.Fatalf("非数字: %q", raw)
  220. }
  221. value = value*10 + int(ch-'0')
  222. }
  223. return value
  224. }
  225. // seedEnrollment 建报课行(**故意把 unpaid 写成垃圾值**,用于证明"欠费口径不用 unpaid")。
  226. func seedEnrollment(t *testing.T, db *gorm.DB, coursesID int64, studentID, bizNo string,
  227. lessonCost, receivable, netReceipts, remainderReceivable, unpaid string) *model.CoursesStudent {
  228. t.Helper()
  229. confirm := courseTestOperator
  230. row := &model.CoursesStudent{
  231. BizNo: bizNo, CoursesID: coursesID, InstitutionID: 1, CampusID: 10,
  232. StudentID: studentID, Type: model.CoursesStudentTypeNormal,
  233. Status: model.CoursesStudentStatusNormal,
  234. Receivable: receivable, NetReceipts: netReceipts, Unpaid: unpaid,
  235. LessonCost: lessonCost, Number: 10, FinishedNumber: 0,
  236. DiscountCash: "0.00", GiveNumber: 0, GiveCost: "0.00",
  237. RemainderNumber: 10, RemainderCost: netReceipts,
  238. RemainderReceivable: remainderReceivable, BadDebt: "0.00",
  239. ConfirmDiscountUserID: &confirm,
  240. }
  241. if err := db.Create(row).Error; err != nil {
  242. t.Fatalf("建报课行失败: %v", err)
  243. }
  244. return row
  245. }
  246. // seedRecord 建排班实例。
  247. func seedRecord(t *testing.T, db *gorm.DB, coursesID, classID int64, bizNo string, status int32, at time.Time) *model.CoursesRecord {
  248. t.Helper()
  249. teacher := courseTestTeacher
  250. end := at.Add(time.Hour)
  251. row := &model.CoursesRecord{
  252. BizNo: bizNo, CoursesID: coursesID, ClassID: classID,
  253. TeacherID: &teacher, InstitutionID: 1, CampusID: 10, Status: status,
  254. StartTime: &at, EndTime: &end,
  255. }
  256. if err := db.Create(row).Error; err != nil {
  257. t.Fatalf("建排班实例失败: %v", err)
  258. }
  259. return row
  260. }
  261. // requireMoney 比较"元字符串"金额(**不比较字面量**)。
  262. //
  263. // 为什么不直接比字符串:SQLite 没有 DECIMAL 类型,`"100.00"` 读回来是 `"100"`;
  264. // 生产 MySQL 读回来是 `"100.00"`。断言要跨两种方言成立,就必须比**分值**而不是比字面量。
  265. func requireMoney(t *testing.T, label, got, want string) {
  266. t.Helper()
  267. if strings.TrimSpace(got) == "" {
  268. t.Fatalf("%s 为空(读不到列),期望 %s", label, want)
  269. }
  270. g, gerr := money.Parse(got)
  271. if gerr != nil {
  272. t.Fatalf("%s = %q 不是合法金额: %v", label, got, gerr)
  273. }
  274. w, werr := money.Parse(want)
  275. if werr != nil {
  276. t.Fatalf("期望值 %q 不是合法金额: %v", want, werr)
  277. }
  278. if g.Cents() != w.Cents() {
  279. t.Fatalf("%s = %q(%d 分),期望 %q(%d 分)", label, got, g.Cents(), want, w.Cents())
  280. }
  281. }
  282. // jsonMap 把响应 data 解成 map(断言"某个键必须不存在"时用)。
  283. func jsonMap(t *testing.T, raw json.RawMessage) map[string]any {
  284. t.Helper()
  285. out := map[string]any{}
  286. if len(raw) == 0 {
  287. return out
  288. }
  289. if err := json.Unmarshal(raw, &out); err != nil {
  290. t.Fatalf("响应 data 不是 JSON 对象: %v(原文 %s)", err, string(raw))
  291. }
  292. return out
  293. }
  294. // pageList 取分页响应的 list 字段([]any)。
  295. func pageList(t *testing.T, raw json.RawMessage) []any {
  296. t.Helper()
  297. got := jsonMap(t, raw)
  298. items, ok := got["list"].([]any)
  299. if !ok {
  300. t.Fatalf("响应缺少 list 数组:%s", string(raw))
  301. }
  302. return items
  303. }
  304. // ---------------------------------------------------------------- 端点 44:课程列表
  305. // TestListCoursesAggregatesTeacherIDsAndRecordCount 端点 44 的两个派生列必须来自**另外两张表**。
  306. //
  307. // 变红条件:
  308. // - `teacherIds` 恒空(漏 join `t_courses_class`)→ 断言 1 红;
  309. // - `recordCount` 恒 0(漏 count `t_courses_record`)→ 断言 2 红;
  310. // - 机构过滤失效(把机构 2 的课程也返回)→ 断言 3 红。
  311. func TestListCoursesAggregatesTeacherIDsAndRecordCount(t *testing.T) {
  312. db := newCourseTestDB(t)
  313. course := seedCourse(t, db, "数学A", 10)
  314. // 两条规则、三个不同老师(含一条重复老师)→ teacherIds 必须去重且升序
  315. seedClassRule(t, db, course.ID, 1001, courseTestTeacher2, "1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  316. seedClassRule(t, db, course.ID, 1001, courseTestTeacher, "3", model.CoursesClassStatusEnded, "11:00", "12:00")
  317. seedClassRule(t, db, course.ID, 1002, courseTestTeacher2, "5", model.CoursesClassStatusOngoing, "13:00", "14:00")
  318. for i := 0; i < 3; i++ {
  319. seedRecord(t, db, course.ID, 1001, "REC"+string(rune('A'+i)), model.CoursesRecordStatusNotStarted,
  320. time.Date(2026, 11, 10+i, 9, 0, 0, 0, time.Local))
  321. }
  322. // 另一机构的课程(不得出现在机构 1 的列表里)
  323. other := &model.Courses{
  324. InstitutionID: 2, CampusID: 20, Name: "别家课程", Status: model.CoursesStatusPublished,
  325. Duration: "1.0", Week: "-1", OriginalCost: "0.00", RealPrice: "0.00", DiscountCash: "0.00",
  326. }
  327. if err := db.Create(other).Error; err != nil {
  328. t.Fatalf("建跨机构课程失败: %v", err)
  329. }
  330. app := newCourseTestApp(t, db)
  331. code, msg, data := doJSON(t, app, fiber.MethodGet, PathCourses, nil, "X-Test-Token", "t")
  332. if code != 200 {
  333. t.Fatalf("GET %s = %d(%s),期望 200", PathCourses, code, msg)
  334. }
  335. payload := jsonMap(t, data)
  336. items, _ := payload["list"].([]any)
  337. if len(items) != 1 {
  338. t.Fatalf("列表行数 = %d,期望 1(跨机构课程必须被 Scoped 过滤):%s", len(items), string(data))
  339. }
  340. row, _ := items[0].(map[string]any)
  341. // 断言 1:teacherIds 去重 + 升序,且**来自 t_courses_class**
  342. teacherIDs, _ := row["teacherIds"].([]any)
  343. if len(teacherIDs) != 2 {
  344. t.Fatalf("teacherIds = %v,期望 2 个(去重后 %s/%s)—— 空数组说明没查 t_courses_class",
  345. row["teacherIds"], courseTestTeacher, courseTestTeacher2)
  346. }
  347. if teacherIDs[0] != courseTestTeacher || teacherIDs[1] != courseTestTeacher2 {
  348. t.Fatalf("teacherIds = %v,期望升序 [%s %s]", teacherIDs, courseTestTeacher, courseTestTeacher2)
  349. }
  350. // 断言 2:recordCount 来自 t_courses_record 计数
  351. if got, _ := row["recordCount"].(float64); got != 3 {
  352. t.Fatalf("recordCount = %v,期望 3(t_courses_record 三行);0 说明没做计数聚合", row["recordCount"])
  353. }
  354. // 断言 3:作用域键(机构/校区)必须下发
  355. if got, _ := row["institutionId"].(float64); got != 1 {
  356. t.Fatalf("institutionId = %v,期望 1", row["institutionId"])
  357. }
  358. }
  359. // ---------------------------------------------------------------- 端点 45:课程 CRUD
  360. // TestCreateCourseIsUnpublished 端点 45 新建:恒落 status=0(未发布),作用域列取 token 而非 body。
  361. //
  362. // 变红条件:把 body 的 status/institutionId 透传进库(或忘写作用域列)→ 库里 status/institution_id 不符。
  363. func TestCreateCourseIsUnpublished(t *testing.T) {
  364. db := newCourseTestDB(t)
  365. app := newCourseTestApp(t, db)
  366. code, msg, data := doJSON(t, app, fiber.MethodPost, PathCourses, map[string]any{
  367. "name": "英语B", "duration": "1.5", "number": 8, "realPrice": "200.00",
  368. "week": "1,3,5", "status": 3, "institutionId": 99, // status/institutionId 必须被忽略
  369. }, "X-Test-Token", "t")
  370. if code != 200 {
  371. t.Fatalf("POST %s = %d(%s),期望 200", PathCourses, code, msg)
  372. }
  373. id, _ := jsonMap(t, data)["id"].(float64)
  374. if id <= 0 {
  375. t.Fatalf("响应 id = %v,期望 >0", jsonMap(t, data)["id"])
  376. }
  377. var row model.Courses
  378. if err := db.First(&row, int64(id)).Error; err != nil {
  379. t.Fatalf("回读课程失败: %v", err)
  380. }
  381. // status 断言拆到 TestCreateCourseStatusIsUnpublished(D11 的回归门禁,含缺陷成因与修法)。
  382. if row.InstitutionID != 1 {
  383. t.Fatalf("institution_id = %d,期望 1(取作用域,不信 body 的 99)", row.InstitutionID)
  384. }
  385. if row.CampusID != 10 {
  386. t.Fatalf("campus_id = %d,期望 10(作用域校区)", row.CampusID)
  387. }
  388. if row.Week != "1,3,5" {
  389. t.Fatalf("week = %q,期望原值 1,3,5", row.Week)
  390. }
  391. // 2001:缺 name
  392. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathCourses, map[string]any{
  393. "duration": "1.0",
  394. }, "X-Test-Token", "t"); code != infraerrors.ErrBadParam.Code {
  395. t.Fatalf("缺 name = %d(%s),期望 2001", code, msg)
  396. }
  397. }
  398. // TestCreateCourseStatusIsUnpublished **新建课程必须落 status=0(未发布)**——D11 的回归门禁。
  399. //
  400. // 缺陷原貌(2026-11-09 实测):`CourseService.CreateCourse` 显式写 `Status=0`,但
  401. // `model.Courses.Status` 的 gorm tag 带 `default:1` ⇒ GORM 对"有 default tag 且值为零"的列
  402. // **跳过该列**、由 DB 默认值填充 ⇒ 落库 `status=1`("新建即发布":课程直接出现在可报名列表)。
  403. // MySQL 与 SQLite 走同一段 GORM 回调,生产同样成立。
  404. //
  405. // 修复(team-lead 裁决):**去掉 `model.Courses.Status` 的 `default:1`(DDL 不动)**,
  406. // 而不是 `tx.Select("*").Create(row)` —— 后者会把 `created_at`/`updated_at` 等零值一并写入,
  407. // 正是 `a1971b7`(审计时间零值落库)修过的反向坑。
  408. //
  409. // 本用例是**回归门禁**:把 `default:1` 加回 tag,本用例必红(实测见交付报告)。
  410. func TestCreateCourseStatusIsUnpublished(t *testing.T) {
  411. db := newCourseTestDB(t)
  412. app := newCourseTestApp(t, db)
  413. code, msg, data := doJSON(t, app, fiber.MethodPost, PathCourses, map[string]any{
  414. "name": "状态测试课", "duration": "1.0",
  415. }, "X-Test-Token", "t")
  416. if code != 200 {
  417. t.Fatalf("POST %s = %d(%s),期望 200", PathCourses, code, msg)
  418. }
  419. id, _ := jsonMap(t, data)["id"].(float64)
  420. var row model.Courses
  421. if err := db.First(&row, int64(id)).Error; err != nil {
  422. t.Fatalf("回读课程失败: %v", err)
  423. }
  424. if row.Status != model.CoursesStatusUnpublished {
  425. t.Fatalf("新建课程 status = %d,期望 0(未发布)—— status 只能走状态机入口", row.Status)
  426. }
  427. }
  428. // TestUpdateCourseIsPartial 端点 45 更新:只改传入列(未传的 name/number 必须保持原值)。
  429. //
  430. // 变红条件:写成"整体替换"(未传字段被清空/归零)→ name 或 number 变空/0。
  431. func TestUpdateCourseIsPartial(t *testing.T) {
  432. db := newCourseTestDB(t)
  433. course := seedCourse(t, db, "物理C", 10)
  434. course.Number = 12
  435. if err := db.Save(course).Error; err != nil {
  436. t.Fatalf("更新种子课程失败: %v", err)
  437. }
  438. app := newCourseTestApp(t, db)
  439. code, msg, _ := doJSON(t, app, fiber.MethodPut, "/admin/courses/"+itoa(course.ID), map[string]any{
  440. "remark": "只改备注",
  441. }, "X-Test-Token", "t")
  442. if code != 200 {
  443. t.Fatalf("PUT 课程 = %d(%s),期望 200", code, msg)
  444. }
  445. var row model.Courses
  446. if err := db.First(&row, course.ID).Error; err != nil {
  447. t.Fatalf("回读课程失败: %v", err)
  448. }
  449. if row.Name != "物理C" {
  450. t.Fatalf("name = %q,期望保持 物理C —— 部分更新被写成了整体替换", row.Name)
  451. }
  452. if row.Number != 12 {
  453. t.Fatalf("number = %d,期望保持 12 —— 未传字段被清零", row.Number)
  454. }
  455. if row.Remark == nil || *row.Remark != "只改备注" {
  456. t.Fatalf("remark = %v,期望 只改备注", row.Remark)
  457. }
  458. }
  459. // itoa 测试用整数转字符串(避免引入 strconv 之外的依赖)。
  460. func itoa(v int64) string {
  461. if v == 0 {
  462. return "0"
  463. }
  464. digits := make([]byte, 0, 20)
  465. for v > 0 {
  466. digits = append([]byte{byte('0' + v%10)}, digits...)
  467. v /= 10
  468. }
  469. return string(digits)
  470. }
  471. // ---------------------------------------------------------------- 端点 46:排班规则
  472. // TestListCourseClassesKeepsEndedRules 端点 46 必须列出**全部**规则(含 status=2 已结束)。
  473. //
  474. // 为什么这条重要:AC-11 的 `ListClasses(onlyActive=true)` 是"排班生成"专用过滤,
  475. // 若 handler 顺手复用它,已结束的规则会静默消失(前端看到的是"这个班没排过课")。
  476. // 变红条件:把 onlyActive 传成 true → total 从 2 变 1。
  477. func TestListCourseClassesKeepsEndedRules(t *testing.T) {
  478. db := newCourseTestDB(t)
  479. course := seedCourse(t, db, "化学D", 10)
  480. seedClassRule(t, db, course.ID, 2001, courseTestTeacher, "1,3,5", model.CoursesClassStatusOngoing, "09:00", "10:00")
  481. seedClassRule(t, db, course.ID, 2002, courseTestTeacher2, "2", model.CoursesClassStatusEnded, "14:00", "15:00")
  482. app := newCourseTestApp(t, db)
  483. code, msg, data := doJSON(t, app, fiber.MethodGet, "/admin/courses/"+itoa(course.ID)+"/classes", nil, "X-Test-Token", "t")
  484. if code != 200 {
  485. t.Fatalf("GET classes = %d(%s),期望 200", code, msg)
  486. }
  487. total, _ := jsonMap(t, data)["total"].(float64)
  488. if total != 2 {
  489. t.Fatalf("total = %v,期望 2(含 status=2 的规则)—— 1 说明误用了 onlyActive 过滤", total)
  490. }
  491. items := pageList(t, data)
  492. first, _ := items[0].(map[string]any)
  493. // week 必须是**原值字符串**(契约写 number 1~7,但该列是多值字符串,见 classRowView 注释)
  494. if week, _ := first["week"].(string); week != "1,3,5" {
  495. t.Fatalf("week = %v(%T),期望原值字符串 \"1,3,5\"", first["week"], first["week"])
  496. }
  497. if _, hasRoom := first["room"]; hasRoom {
  498. t.Fatalf("响应出现了 room 字段(%s):t_courses_class 没有 room 列,不得下发", string(data))
  499. }
  500. }
  501. // ---------------------------------------------------------------- 端点 47:新建排班规则
  502. // TestCreateCourseClassConflictReturns3122 端点 47:同老师 + 同周 + 时段重叠 → 3122。
  503. //
  504. // 变红条件:去掉冲突判定 → 冲突请求返回 200(并且库里多出一条重叠规则)。
  505. func TestCreateCourseClassConflictReturns3122(t *testing.T) {
  506. db := newCourseTestDB(t)
  507. course := seedCourse(t, db, "生物E", 10)
  508. seedClassRule(t, db, course.ID, 3001, courseTestTeacher, "1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  509. app := newCourseTestApp(t, db)
  510. base := map[string]any{
  511. "teacherId": courseTestTeacher, "week": "1", "start": "09:30", "end": "10:30",
  512. "lessonCost": "100.00", "number": 10,
  513. }
  514. code, msg, _ := doJSON(t, app, fiber.MethodPost, "/admin/courses/"+itoa(course.ID)+"/classes", base, "X-Test-Token", "t")
  515. if code != apperr.CodeScheduleConflict {
  516. t.Fatalf("重叠排班 = %d(%s),期望 3122(排班冲突)", code, msg)
  517. }
  518. var count int64
  519. db.Model(&model.CoursesClass{}).Where("courses_id = ?", course.ID).Count(&count)
  520. if count != 1 {
  521. t.Fatalf("冲突被拒后规则数 = %d,期望仍为 1(不得先写后报错)", count)
  522. }
  523. // 对照:换一天(week=2)必须成功,否则说明冲突判定过宽
  524. okBody := map[string]any{
  525. "teacherId": courseTestTeacher, "week": "2", "start": "09:30", "end": "10:30",
  526. "lessonCost": "100.00", "number": 10,
  527. }
  528. code, msg, data := doJSON(t, app, fiber.MethodPost, "/admin/courses/"+itoa(course.ID)+"/classes", okBody, "X-Test-Token", "t")
  529. if code != 200 {
  530. t.Fatalf("不同周的排班 = %d(%s),期望 200(冲突判定过宽)", code, msg)
  531. }
  532. if _, ok := jsonMap(t, data)["classId"]; !ok {
  533. t.Fatalf("响应缺 classId:%s", string(data))
  534. }
  535. }
  536. // ---------------------------------------------------------------- 端点 49:生成课表
  537. // TestGenerateRecordsIdempotent 端点 49 幂等:同 courses+start_time 不重复插。
  538. //
  539. // 变红条件:去掉 `FindByCoursesStart` 幂等判据 → 第二次 generated>0、库里行数翻倍。
  540. func TestGenerateRecordsIdempotent(t *testing.T) {
  541. db := newCourseTestDB(t)
  542. course := seedCourse(t, db, "地理F", 10)
  543. seedClassRule(t, db, course.ID, 4001, courseTestTeacher, "-1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  544. app := newCourseTestApp(t, db)
  545. body := map[string]any{"days": 3, "from": "2026-11-10"}
  546. code, msg, data := doJSON(t, app, fiber.MethodPost, "/admin/courses/"+itoa(course.ID)+"/records/generate", body, "X-Test-Token", "t")
  547. if code != 200 {
  548. t.Fatalf("生成课表 = %d(%s),期望 200", code, msg)
  549. }
  550. if got, _ := jsonMap(t, data)["generated"].(float64); got != 3 {
  551. t.Fatalf("首次 generated = %v,期望 3", jsonMap(t, data)["generated"])
  552. }
  553. code, msg, data = doJSON(t, app, fiber.MethodPost, "/admin/courses/"+itoa(course.ID)+"/records/generate", body, "X-Test-Token", "t")
  554. if code != 200 {
  555. t.Fatalf("二次生成 = %d(%s),期望 200", code, msg)
  556. }
  557. payload := jsonMap(t, data)
  558. if got, _ := payload["generated"].(float64); got != 0 {
  559. t.Fatalf("二次 generated = %v,期望 0(幂等:同 courses+start_time 不重复插)", payload["generated"])
  560. }
  561. if changed, _ := payload["changed"].(bool); changed {
  562. t.Fatalf("二次 changed = true,期望 false(本次无新增)")
  563. }
  564. var count int64
  565. db.Model(&model.CoursesRecord{}).Where("courses_id = ?", course.ID).Count(&count)
  566. if count != 3 {
  567. t.Fatalf("库中实例数 = %d,期望 3(幂等失败会翻倍成 6)", count)
  568. }
  569. }
  570. // ---------------------------------------------------------------- 端点 50 / 52:开始上课 / 打卡
  571. // TestStartRecordWritesActualStart 端点 50:status 0→1 且 `actual_start_time` 落库;重复开始 → 3121。
  572. //
  573. // 变红条件:只改 status 不写 actual_start_time → 断言 1 红;重复开始返回 200 → 断言 2 红。
  574. func TestStartRecordWritesActualStart(t *testing.T) {
  575. db := newCourseTestDB(t)
  576. course := seedCourse(t, db, "历史G", 10)
  577. record := seedRecord(t, db, course.ID, 5001, "RECSTART", model.CoursesRecordStatusNotStarted,
  578. time.Now().Add(-time.Hour))
  579. app := newCourseTestApp(t, db)
  580. path := "/admin/courses/records/" + itoa(record.ID) + "/start"
  581. code, msg, data := doJSON(t, app, fiber.MethodPost, path, nil, "X-Test-Token", "t")
  582. if code != 200 {
  583. t.Fatalf("开始上课 = %d(%s),期望 200", code, msg)
  584. }
  585. payload := jsonMap(t, data)
  586. if got, _ := payload["status"].(float64); got != float64(model.CoursesRecordStatusOngoing) {
  587. t.Fatalf("status = %v,期望 1", payload["status"])
  588. }
  589. if got, _ := payload["courseId"].(float64); got != float64(course.ID) {
  590. t.Fatalf("courseId = %v,期望 %d", payload["courseId"], course.ID)
  591. }
  592. var row struct {
  593. Status int32 `gorm:"column:status"`
  594. ActualStart *time.Time `gorm:"column:actual_start_time"`
  595. }
  596. if err := db.Raw("SELECT status, actual_start_time FROM t_courses_record WHERE id = ?", record.ID).Scan(&row).Error; err != nil {
  597. t.Fatalf("回读实例失败: %v", err)
  598. }
  599. if row.Status != model.CoursesRecordStatusOngoing || row.ActualStart == nil {
  600. t.Fatalf("库里 status=%d actual_start_time=%v,期望 1 且非空(模型红线:开课时间必写)", row.Status, row.ActualStart)
  601. }
  602. // 重复开始 → 3121(不会写出第二个开课时间)
  603. if code, msg, _ := doJSON(t, app, fiber.MethodPost, path, nil, "X-Test-Token", "t"); code != apperr.CodeRecordStateInvalid {
  604. t.Fatalf("重复开始上课 = %d(%s),期望 3121", code, msg)
  605. }
  606. }
  607. // TestAttendanceRejectsFinishedRecord 端点 52:已结束的课不能补打卡(3121);未结束则写 cost 并回显人数。
  608. //
  609. // 变红条件:去掉"已结束"判定 → 返回 200 且库中出现结课后追加的打卡行(income 对账缺口)。
  610. func TestAttendanceRejectsFinishedRecord(t *testing.T) {
  611. db := newCourseTestDB(t)
  612. course := seedCourse(t, db, "政治H", 10)
  613. open := seedRecord(t, db, course.ID, 6001, "RECOPEN", model.CoursesRecordStatusOngoing,
  614. time.Now().Add(-time.Hour))
  615. closed := seedRecord(t, db, course.ID, 6001, "RECCLOSED", model.CoursesRecordStatusFinished,
  616. time.Now().Add(-24*time.Hour))
  617. app := newCourseTestApp(t, db)
  618. body := map[string]any{"list": []map[string]any{
  619. {"userId": courseTestStudent, "type": 1, "pay": 1, "cost": "100.00", "giveCost": "0.00"},
  620. }}
  621. code, msg, data := doJSON(t, app, fiber.MethodPost,
  622. "/admin/courses/records/"+itoa(open.ID)+"/attendance", body, "X-Test-Token", "t")
  623. if code != 200 {
  624. t.Fatalf("未结束课打卡 = %d(%s),期望 200", code, msg)
  625. }
  626. if got, _ := jsonMap(t, data)["checked"].(float64); got != 1 {
  627. t.Fatalf("checked = %v,期望 1", jsonMap(t, data)["checked"])
  628. }
  629. var cost struct {
  630. Cost string `gorm:"column:cost"`
  631. Pay int8 `gorm:"column:pay"`
  632. Typ int32 `gorm:"column:type"`
  633. }
  634. if err := db.Raw("SELECT cost, pay, type FROM t_courses_record_student WHERE record_id = ? AND student_id = ?",
  635. open.ID, courseTestStudent).Scan(&cost).Error; err != nil {
  636. t.Fatalf("回读打卡行失败: %v", err)
  637. }
  638. requireMoney(t, "打卡行 cost", cost.Cost, "100.00")
  639. // 已结束的课 → 3121
  640. code, msg, _ = doJSON(t, app, fiber.MethodPost,
  641. "/admin/courses/records/"+itoa(closed.ID)+"/attendance", body, "X-Test-Token", "t")
  642. if code != apperr.CodeRecordStateInvalid {
  643. t.Fatalf("已结束课补打卡 = %d(%s),期望 3121", code, msg)
  644. }
  645. }
  646. // ---------------------------------------------------------------- 端点 53:报课学生
  647. // TestListCourseStudentsUsesRemainderReceivable 端点 53 的欠费字段必须取 `remainder_receivable`。
  648. //
  649. // 陷阱行:`unpaid=999.00`(僵尸列的脏值)、`remainder_receivable=100.00`(真值)。
  650. // 变红条件:字段取成 `unpaid` → 响应里 remainderReceivable 变成 999.00;
  651. //
  652. // 把 unpaid 一起下发 → 断言"响应不含 unpaid 键"红。
  653. func TestListCourseStudentsUsesRemainderReceivable(t *testing.T) {
  654. db := newCourseTestDB(t)
  655. course := seedCourse(t, db, "语文I", 10)
  656. seedEnrollment(t, db, course.ID, courseTestStudent, "ENROLL-1", "100.00", "400.00", "300.00", "100.00", "999.00")
  657. app := newCourseTestApp(t, db)
  658. code, msg, data := doJSON(t, app, fiber.MethodGet,
  659. "/admin/courses/"+itoa(course.ID)+"/students", nil, "X-Test-Token", "t")
  660. if code != 200 {
  661. t.Fatalf("报课学生列表 = %d(%s),期望 200", code, msg)
  662. }
  663. items := pageList(t, data)
  664. if len(items) != 1 {
  665. t.Fatalf("行数 = %d,期望 1", len(items))
  666. }
  667. row, _ := items[0].(map[string]any)
  668. if got, _ := row["remainderReceivable"].(string); got != "100.00" {
  669. t.Fatalf("remainderReceivable = %v,期望 \"100.00\"(源列 remainder_receivable);"+
  670. "若为 999.00 说明误取了废弃列 unpaid", row["remainderReceivable"])
  671. }
  672. if got, _ := row["pay"].(string); got != "400.00" {
  673. t.Fatalf("pay = %v,期望 400.00(源列 receivable)", row["pay"])
  674. }
  675. if got, _ := row["cost"].(string); got != "300.00" {
  676. t.Fatalf("cost = %v,期望 300.00(源列 net_receipts)", row["cost"])
  677. }
  678. if _, hasUnpaid := row["unpaid"]; hasUnpaid {
  679. t.Fatalf("响应下发了 unpaid(%s):废弃列禁下发(设计 §3.8-E4)", string(data))
  680. }
  681. // 未注入姓名端口时 `realName` 必须是 **null**(键在、值为 nil):
  682. // - 不下发该键 → 前端 `row.realName` undefined 与 "" 混在一起,无法区分;
  683. // - 下发 "" → 把"没有这个人"和"姓名为空"混在一起。
  684. nameValue, hasName := row["realName"]
  685. if !hasName {
  686. t.Fatalf("响应缺少 realName 键(%s):未注入端口时应下发 null,而不是省掉该键", string(data))
  687. }
  688. if nameValue != nil {
  689. t.Fatalf("realName = %v,期望 null(未注入姓名端口)", nameValue)
  690. }
  691. }
  692. // fakeUserNameReader 姓名端口测试替身(**只实现端口契约**:查不到的不进 map)。
  693. type fakeUserNameReader struct {
  694. names map[string]string
  695. err error
  696. // calls 记录调用次数(断言"批量一次"而不是逐行 N 次)
  697. calls int
  698. last []string
  699. }
  700. // DisplayNames 实现 `port.UserNameReader`。
  701. func (f *fakeUserNameReader) DisplayNames(_ context.Context, userIDs []string) (map[string]string, error) {
  702. f.calls++
  703. f.last = append([]string{}, userIDs...)
  704. if f.err != nil {
  705. return nil, f.err
  706. }
  707. out := make(map[string]string, len(userIDs))
  708. for _, id := range userIDs {
  709. if name, ok := f.names[id]; ok {
  710. out[id] = name
  711. }
  712. }
  713. return out, nil
  714. }
  715. // TestListCourseStudentsResolvesRealName 端点 53 的 `realName`(D4:跨域只读 port)。
  716. //
  717. // 三行数据覆盖三种情形:
  718. //
  719. // A:端口能查到 → `realName` = 姓名
  720. // B:端口查不到 → `realName` = **null**(不是 "")
  721. // C:端口返回空串 → 同样按"没名字"→ null(空串不该出现在响应里)
  722. //
  723. // 变红条件:
  724. // - 端口没接(仍是 null)→ A 红;
  725. // - 用空串兜底 → B/C 红;
  726. // - 逐行查询 → `calls != 1` 红(N+1)。
  727. func TestListCourseStudentsResolvesRealName(t *testing.T) {
  728. db := newCourseTestDB(t)
  729. course := seedCourse(t, db, "姓名测试课", 10)
  730. const studentB = "01HSTUDENT0000000000000B"
  731. const studentC = "01HSTUDENT0000000000000C"
  732. seedEnrollment(t, db, course.ID, courseTestStudent, "NAME-1", "100.00", "300.00", "300.00", "0.00", "0.00")
  733. seedEnrollment(t, db, course.ID, studentB, "NAME-2", "100.00", "300.00", "300.00", "0.00", "0.00")
  734. seedEnrollment(t, db, course.ID, studentC, "NAME-3", "100.00", "300.00", "300.00", "0.00", "0.00")
  735. reader := &fakeUserNameReader{names: map[string]string{
  736. courseTestStudent: "张三",
  737. studentC: "", // 端口返回空串:调用方必须当成"没名字"
  738. }}
  739. app := newCourseTestAppWithUsers(t, db, reader)
  740. code, msg, data := doJSON(t, app, fiber.MethodGet,
  741. "/admin/courses/"+itoa(course.ID)+"/students?pageSize=50", nil, "X-Test-Token", "t")
  742. if code != 200 {
  743. t.Fatalf("报课学生列表 = %d(%s),期望 200", code, msg)
  744. }
  745. items := pageList(t, data)
  746. if len(items) != 3 {
  747. t.Fatalf("行数 = %d,期望 3", len(items))
  748. }
  749. byUser := make(map[string]map[string]any, len(items))
  750. for _, item := range items {
  751. row, _ := item.(map[string]any)
  752. uid, _ := row["userId"].(string)
  753. byUser[uid] = row
  754. }
  755. if got, _ := byUser[courseTestStudent]["realName"].(string); got != "张三" {
  756. t.Fatalf("A 行 realName = %v,期望 张三(端口已查到,不得为 null)",
  757. byUser[courseTestStudent]["realName"])
  758. }
  759. if v, ok := byUser[studentB]["realName"]; !ok || v != nil {
  760. t.Fatalf("B 行 realName = %v,期望 null(端口查不到;空串会让前端无法区分两种没名字)", v)
  761. }
  762. if v, ok := byUser[studentC]["realName"]; !ok || v != nil {
  763. t.Fatalf("C 行 realName = %v,期望 null(端口返回空串 ⇒ 等同于没名字)", v)
  764. }
  765. // 批量:一页 3 行只应调用端口 1 次(N+1 会变成 3 次)
  766. if reader.calls != 1 {
  767. t.Fatalf("姓名端口调用 %d 次,期望 1 次(批量)—— 多次说明逐行查", reader.calls)
  768. }
  769. if len(reader.last) != 3 {
  770. t.Fatalf("端口收到 %d 个 ID,期望 3(一页全部学生一次传入)", len(reader.last))
  771. }
  772. }
  773. // TestListCourseStudentsNameReaderFailureDegradesToNull 端口报错时**降级为 null**、列表仍 200。
  774. //
  775. // 为什么不让它 5002:列表页因"少一列姓名"整页失败,用户连报课/欠费都看不到——
  776. // 展示类依赖必须可降级(与 `MembershipChecker` 那种安全依赖相反)。
  777. func TestListCourseStudentsNameReaderFailureDegradesToNull(t *testing.T) {
  778. db := newCourseTestDB(t)
  779. course := seedCourse(t, db, "降级测试课", 10)
  780. seedEnrollment(t, db, course.ID, courseTestStudent, "DEGRADE-1", "100.00", "300.00", "300.00", "0.00", "0.00")
  781. reader := &fakeUserNameReader{err: errors.New("identity 库不可用")}
  782. app := newCourseTestAppWithUsers(t, db, reader)
  783. code, msg, data := doJSON(t, app, fiber.MethodGet,
  784. "/admin/courses/"+itoa(course.ID)+"/students", nil, "X-Test-Token", "t")
  785. if code != 200 {
  786. t.Fatalf("姓名端口报错时列表 = %d(%s),期望 200(展示类依赖可降级)", code, msg)
  787. }
  788. items := pageList(t, data)
  789. if len(items) != 1 {
  790. t.Fatalf("行数 = %d,期望 1(降级不影响数据行)", len(items))
  791. }
  792. row, _ := items[0].(map[string]any)
  793. if v, ok := row["realName"]; !ok || v != nil {
  794. t.Fatalf("realName = %v,期望 null(端口报错时降级)", v)
  795. }
  796. if got, _ := row["remainderReceivable"].(string); got != "0.00" {
  797. t.Fatalf("remainderReceivable = %v,期望 0.00(降级不得影响其它字段)", row["remainderReceivable"])
  798. }
  799. }
  800. // ---------------------------------------------------------------- 端点 54:报名
  801. // TestEnrollCreatesSnapshotAndRejectsDuplicate 端点 54 报课行快照恒等式 + 重复报名 3140 + 跨校区 1004。
  802. //
  803. // 变红条件:
  804. // - receivable ≠ net_receipts + remainder_receivable → 对账恒等式断言红;
  805. // - `confirm_discount_user_id` 为空 → 该行永远进不了欠费核销候选,断言红;
  806. // - 重复报名静默成功 → 库里出现第二行(断言行数)。
  807. func TestEnrollCreatesSnapshotAndRejectsDuplicate(t *testing.T) {
  808. db := newCourseTestDB(t)
  809. course := seedCourse(t, db, "化学J", 10)
  810. app := newCourseTestApp(t, db)
  811. path := "/admin/courses/" + itoa(course.ID) + "/students"
  812. body := map[string]any{
  813. "userId": courseTestStudent, "pay": "500.00", "remainderReceivable": "200.00",
  814. "lessonCost": "100.00", "number": 5, "giveNumber": 1,
  815. }
  816. code, msg, data := doJSON(t, app, fiber.MethodPost, path, body, "X-Test-Token", "t")
  817. if code != 200 {
  818. t.Fatalf("报名 = %d(%s),期望 200", code, msg)
  819. }
  820. payload := jsonMap(t, data)
  821. if enrolled, _ := payload["enrolled"].(bool); !enrolled {
  822. t.Fatalf("enrolled = %v,期望 true", payload["enrolled"])
  823. }
  824. var row model.CoursesStudent
  825. if err := db.Where("courses_id = ? AND student_id = ?", course.ID, courseTestStudent).First(&row).Error; err != nil {
  826. t.Fatalf("回读报课行失败: %v", err)
  827. }
  828. // 恒等式:receivable = net_receipts + remainder_receivable(这是"应收"的唯一定义)
  829. receivable, _ := money.Parse(row.Receivable)
  830. netReceipts, _ := money.Parse(row.NetReceipts)
  831. remainder, _ := money.Parse(row.RemainderReceivable)
  832. if receivable.Cents() != netReceipts.Cents()+remainder.Cents() {
  833. t.Fatalf("receivable(%s) ≠ net_receipts(%s) + remainder_receivable(%s):应收恒等式被破坏",
  834. row.Receivable, row.NetReceipts, row.RemainderReceivable)
  835. }
  836. if row.RemainderNumber != 6 {
  837. t.Fatalf("remainder_number = %d,期望 6(number 5 + give_number 1)", row.RemainderNumber)
  838. }
  839. if row.ConfirmDiscountUserID == nil || strings.TrimSpace(*row.ConfirmDiscountUserID) == "" {
  840. t.Fatalf("confirm_discount_user_id 为空:该报课行将**永远进不了欠费核销候选**(§3.8-A17)")
  841. }
  842. requireMoney(t, "unpaid(废弃列)", row.Unpaid, "0.00")
  843. // 重复报名 → 3140,且库里仍只有一行
  844. code, msg, _ = doJSON(t, app, fiber.MethodPost, path, body, "X-Test-Token", "t")
  845. if code != apperr.CodeEnrollmentDuplicate {
  846. t.Fatalf("重复报名 = %d(%s),期望 3143(重复报名)", code, msg)
  847. }
  848. var count int64
  849. db.Model(&model.CoursesStudent{}).Where("courses_id = ? AND student_id = ?", course.ID, courseTestStudent).Count(&count)
  850. if count != 1 {
  851. t.Fatalf("报课行数 = %d,期望 1", count)
  852. }
  853. // 跨校区报名 → 1004(作用域校区 10,传入 99)
  854. crossBody := map[string]any{
  855. "userId": courseTestOther, "pay": "100.00", "lessonCost": "100.00", "campusId": 99,
  856. }
  857. if code, msg, _ := doJSON(t, app, fiber.MethodPost, path, crossBody, "X-Test-Token", "t"); code != infraerrors.ErrUnscoped.Code {
  858. t.Fatalf("跨校区报名 = %d(%s),期望 1004", code, msg)
  859. }
  860. }
  861. // ---------------------------------------------------------------- 端点 55:欠费列表
  862. // TestArrearsListUsesRemainderReceivable **本端点最容易写错、且写错不会报错的一处**。
  863. //
  864. // 两条数据:
  865. //
  866. // A:remainder_receivable=50.00 且 unpaid=0.00 ← **真欠费**(用 unpaid 判会被漏掉)
  867. // B:remainder_receivable=0.00 且 unpaid=999.00 ← **不欠费**(用 unpaid 判会被误报)
  868. //
  869. // 变红条件:判据换成 `unpaid > 0` → 列表里出现 B、且不含 A(两条断言同时红)。
  870. func TestArrearsListUsesRemainderReceivable(t *testing.T) {
  871. db := newCourseTestDB(t)
  872. course := seedCourse(t, db, "英语K", 10)
  873. seedEnrollment(t, db, course.ID, courseTestStudent, "ARR-1", "100.00", "300.00", "250.00", "50.00", "0.00")
  874. seedEnrollment(t, db, course.ID, courseTestOther, "ARR-2", "100.00", "300.00", "300.00", "0.00", "999.00")
  875. app := newCourseTestApp(t, db)
  876. code, msg, data := doJSON(t, app, fiber.MethodGet, PathCourseArrears, nil, "X-Test-Token", "t")
  877. if code != 200 {
  878. t.Fatalf("欠费列表 = %d(%s),期望 200", code, msg)
  879. }
  880. items := pageList(t, data)
  881. if len(items) != 1 {
  882. t.Fatalf("欠费行数 = %d,期望 1(只有 remainder_receivable>0 的那条):%s", len(items), string(data))
  883. }
  884. row, _ := items[0].(map[string]any)
  885. if got, _ := row["studentId"].(string); got != courseTestStudent {
  886. t.Fatalf("欠费学生 = %v,期望 %s —— 若为 %s 说明判据用了废弃列 unpaid",
  887. row["studentId"], courseTestStudent, courseTestOther)
  888. }
  889. if got, _ := row["remainderReceivable"].(string); got != "50.00" {
  890. t.Fatalf("remainderReceivable = %v,期望 \"50.00\"", row["remainderReceivable"])
  891. }
  892. if got, _ := row["courseId"].(float64); got != float64(course.ID) {
  893. t.Fatalf("courseId = %v,期望 %d", row["courseId"], course.ID)
  894. }
  895. if _, has := row["unpaid"]; has {
  896. t.Fatalf("欠费列表下发了 unpaid:废弃列禁下发(设计 §3.8-E4)")
  897. }
  898. }
  899. // ---------------------------------------------------------------- 端点 56:欠费核销
  900. // TestCounteractArrearsWritesBothColumns 端点 56:`net_receipts` 增、`remainder_receivable` 减(同一条 UPDATE);
  901. // 跨机构 → 1004。
  902. //
  903. // 变红条件:只写一列(实收加了、应收没减)→ 两列断言之一红;去掉机构校验 → 1004 用例红。
  904. func TestCounteractArrearsWritesBothColumns(t *testing.T) {
  905. db := newCourseTestDB(t)
  906. course := seedCourse(t, db, "数学L", 10)
  907. // SP27 的候选集要 INNER JOIN t_courses_class(按 courses_id + class_id),故必须有一条规则
  908. seedClassRule(t, db, course.ID, 7001, courseTestTeacher, "1", model.CoursesClassStatusOngoing, "09:00", "10:00")
  909. enroll := seedEnrollment(t, db, course.ID, courseTestStudent, "CARR-1", "100.00", "300.00", "200.00", "100.00", "0.00")
  910. // SP27 的候选集是 `t1 INNER JOIN t_courses_class ON (coursesid, classid)` ⇒ 报课行的
  911. // class_id 必须与排班规则一致,否则候选集为空(核销变成静默 no-op)
  912. if err := db.Model(&model.CoursesStudent{}).Where("id = ?", enroll.ID).
  913. UpdateColumn("class_id", 7001).Error; err != nil {
  914. t.Fatalf("对齐报课行 class_id 失败: %v", err)
  915. }
  916. app := newCourseTestApp(t, db)
  917. body := map[string]any{
  918. "studentId": courseTestStudent, "institutionId": 1, "campusId": 10, "money": "60.00",
  919. }
  920. code, msg, data := doJSON(t, app, fiber.MethodPost, PathCourseArrearsCounteract, body, "X-Test-Token", "t")
  921. if code != 200 {
  922. t.Fatalf("欠费核销 = %d(%s),期望 200", code, msg)
  923. }
  924. payload := jsonMap(t, data)
  925. if counteracted, _ := payload["counteracted"].(bool); !counteracted {
  926. t.Fatalf("counteracted = %v,期望 true", payload["counteracted"])
  927. }
  928. if got, _ := payload["amount"].(string); got != "60.00" {
  929. t.Fatalf("amount = %v,期望 \"60.00\"(实际核销额)", payload["amount"])
  930. }
  931. var row struct {
  932. NetReceipts string `gorm:"column:net_receipts"`
  933. Remainder string `gorm:"column:remainder_receivable"`
  934. }
  935. if err := db.Raw("SELECT net_receipts, remainder_receivable FROM t_courses_student WHERE id = ?", enroll.ID).
  936. Scan(&row).Error; err != nil {
  937. t.Fatalf("回读报课行失败: %v", err)
  938. }
  939. requireMoney(t, "net_receipts", row.NetReceipts, "260.00") // 200 + 60
  940. requireMoney(t, "remainder_receivable", row.Remainder, "40.00") // 100 - 60(只加实收不减应收是典型错法)
  941. // 跨机构(作用域机构 1,传入 2)→ 1004
  942. crossBody := map[string]any{
  943. "studentId": courseTestStudent, "institutionId": 2, "campusId": 10, "money": "10.00",
  944. }
  945. if code, msg, _ := doJSON(t, app, fiber.MethodPost, PathCourseArrearsCounteract, crossBody, "X-Test-Token", "t"); code != infraerrors.ErrUnscoped.Code {
  946. t.Fatalf("跨机构核销 = %d(%s),期望 1004", code, msg)
  947. }
  948. }
  949. // ---------------------------------------------------------------- 端点 57:学生课表
  950. // TestStudentScheduleIsPerStudent 端点 57:课表按学生过滤(另一个学生报的课不得出现);跨用户查 → 1004。
  951. //
  952. // 变红条件:漏掉 `s.student_id = ?` 过滤 → 两个学生都会看到两门课(行数 2)。
  953. func TestStudentScheduleIsPerStudent(t *testing.T) {
  954. db := newCourseTestDB(t)
  955. mine := seedCourse(t, db, "我的课", 10)
  956. other := seedCourse(t, db, "别人的课", 10)
  957. seedEnrollment(t, db, mine.ID, courseTestStudent, "SCH-1", "100.00", "100.00", "100.00", "0.00", "0.00")
  958. seedEnrollment(t, db, other.ID, courseTestOther, "SCH-2", "100.00", "100.00", "100.00", "0.00", "0.00")
  959. mineRecord := seedRecord(t, db, mine.ID, 8001, "SCHREC-1", model.CoursesRecordStatusOngoing,
  960. time.Date(2026, 11, 20, 9, 0, 0, 0, time.Local))
  961. seedRecord(t, db, other.ID, 8002, "SCHREC-2", model.CoursesRecordStatusOngoing,
  962. time.Date(2026, 11, 20, 11, 0, 0, 0, time.Local))
  963. // 本人已打卡 → cost 回显
  964. att := &model.CoursesRecordStudent{
  965. BizNo: "SCHATT-1", CoursesID: mine.ID, ClassID: 8001, InstitutionID: 1, CampusID: 10,
  966. RecordID: mineRecord.ID, StudentID: courseTestStudent, Type: model.CoursesRecordStudentTypeNormal,
  967. StartTime: *mineRecord.StartTime, Cost: "100.00", GiveCost: "10.00",
  968. Pay: model.CoursesRecordStudentPayPaid,
  969. }
  970. if err := db.Create(att).Error; err != nil {
  971. t.Fatalf("建打卡行失败: %v", err)
  972. }
  973. app := newCourseTestApp(t, db)
  974. code, msg, data := doJSON(t, app, fiber.MethodGet, PathStudentSchedule, nil,
  975. "X-Test-Token", "t", "X-Test-Scope", "student")
  976. if code != 200 {
  977. t.Fatalf("学生课表 = %d(%s),期望 200", code, msg)
  978. }
  979. items := pageList(t, data)
  980. if len(items) != 1 {
  981. t.Fatalf("课表行数 = %d,期望 1(只含本人报名的课程)—— 2 说明漏了 student_id 过滤:%s",
  982. len(items), string(data))
  983. }
  984. row, _ := items[0].(map[string]any)
  985. if got, _ := row["courseId"].(float64); got != float64(mine.ID) {
  986. t.Fatalf("courseId = %v,期望 %d(本人课程)", row["courseId"], mine.ID)
  987. }
  988. if checked, _ := row["checked"].(bool); !checked {
  989. t.Fatalf("checked = false,期望 true(本人已有打卡行)")
  990. }
  991. if got, _ := row["cost"].(string); got != "100.00" {
  992. t.Fatalf("cost = %v,期望 \"100.00\"", row["cost"])
  993. }
  994. if got, _ := row["courseName"].(string); got != "我的课" {
  995. t.Fatalf("courseName = %v,期望 我的课", row["courseName"])
  996. }
  997. // 学生查别人 → 1004
  998. if code, msg, _ := doJSON(t, app, fiber.MethodGet,
  999. PathStudentSchedule+"?userId="+courseTestOther, nil,
  1000. "X-Test-Token", "t", "X-Test-Scope", "student"); code != infraerrors.ErrUnscoped.Code {
  1001. t.Fatalf("学生查他人课表 = %d(%s),期望 1004", code, msg)
  1002. }
  1003. }
  1004. // ---------------------------------------------------------------- 端点 51:结束上课(跨 5 表)
  1005. // courseFinishFixture 端点 51 的完整夹具(结课链路的五张表全部就位)。
  1006. type courseFinishFixture struct {
  1007. Course *model.Courses
  1008. Record *model.CoursesRecord
  1009. Enroll *model.CoursesStudent
  1010. DetailID int64
  1011. Recommender string
  1012. Upline string
  1013. }
  1014. // seedFinishFixture 造一节课的完整数据:资金双账户 + 报课行 + 排班实例 + 分账树 + 课酬方案。
  1015. //
  1016. // 关键设计(每条都对应一个断言):
  1017. // - 报课行 lesson_cost=100 → 全勤结课的 cost 应为 100.00;
  1018. // - 分账树:推荐人 A 的上级 B 的 quota=20.00 → 结课后 B 应入账 20.00;
  1019. // - 课酬方案:命中 detail 的 reward=100.00 → record.teacher_reward 应为 100.00 且 detailId == 该行 ID。
  1020. func seedFinishFixture(t *testing.T, db *gorm.DB) *courseFinishFixture {
  1021. t.Helper()
  1022. // ① 课程 + 分类(课酬匹配要用 class_type)
  1023. classify := &model.CoursesClassify{
  1024. InstitutionID: 1, CampusID: 10, ClassType: 1000, GradeID: 0, SubjectID: 0,
  1025. Name: "集体班", UnitPrice: "100.00", MinPeople: 1, MaxPeople: 10,
  1026. }
  1027. if err := db.Create(classify).Error; err != nil {
  1028. t.Fatalf("建分类失败: %v", err)
  1029. }
  1030. course := &model.Courses{
  1031. InstitutionID: 1, CampusID: 10, ClassifyID: classify.ID, Name: "结课测试课",
  1032. Status: model.CoursesStatusOngoing, Number: 10, Duration: "1.0", Week: "-1",
  1033. OriginalCost: "100.00", RealPrice: "100.00", DiscountCash: "0.00",
  1034. }
  1035. if err := db.Create(course).Error; err != nil {
  1036. t.Fatalf("建课程失败: %v", err)
  1037. }
  1038. // ② 资金双账户(spend 统计列的累加对象)
  1039. if err := db.Create(&model.UserExpense{
  1040. UserID: courseTestStudent, Balance: "1000.00", Spend: "0.00",
  1041. TotalIncome: "1000.00", TotalExpenditure: "0.00",
  1042. TotalRecommendedAmount: "0.00", SpecialExpenses: "0.00",
  1043. }).Error; err != nil {
  1044. t.Fatalf("建全局账户失败: %v", err)
  1045. }
  1046. if err := db.Create(&model.UserExpenseSchool{
  1047. UserID: courseTestStudent, InstitutionID: 1, CampusID: 10, Balance: "500.00", Spend: "0.00",
  1048. TotalIncome: "500.00", TotalExpenditure: "0.00",
  1049. TotalRecommendedAmount: "0.00", SpecialExpenses: "0.00",
  1050. }).Error; err != nil {
  1051. t.Fatalf("建校区账户失败: %v", err)
  1052. }
  1053. // ③ 报课行(带推荐人 → 结课触发分账)
  1054. confirm := courseTestOperator
  1055. recommender := courseTestRecommender
  1056. enroll := &model.CoursesStudent{
  1057. BizNo: "FINISH-ENROLL-1", CoursesID: course.ID, ClassID: 9001,
  1058. InstitutionID: 1, CampusID: 10, StudentID: courseTestStudent,
  1059. Type: model.CoursesStudentTypeNormal, Status: model.CoursesStudentStatusNormal,
  1060. Receivable: "1000.00", NetReceipts: "1000.00", Unpaid: "0.00",
  1061. LessonCost: "100.00", Number: 10, FinishedNumber: 0, DiscountCash: "0.00",
  1062. GiveNumber: 0, GiveCost: "0.00", RemainderNumber: 10, RemainderCost: "1000.00",
  1063. RemainderReceivable: "0.00", BadDebt: "0.00",
  1064. ConfirmDiscountUserID: &confirm, RecommenderUserID: &recommender,
  1065. }
  1066. if err := db.Create(enroll).Error; err != nil {
  1067. t.Fatalf("建报课行失败: %v", err)
  1068. }
  1069. // ④ 排班实例(上课中)
  1070. record := seedRecord(t, db, course.ID, 9001, "FINISH-REC-1", model.CoursesRecordStatusOngoing,
  1071. time.Now().Add(-time.Hour))
  1072. // ⑤ 分账树:B(根,quota 20)→ A(推荐人)
  1073. parent := courseTestUpline
  1074. root := courseTestUpline
  1075. if err := db.Create(&model.UserDivideInto{
  1076. UserID: courseTestUpline, Type: model.DivideTypePerLesson, Quota: "20.00", TotalIncome: "0.00",
  1077. RootUserID: &root, ParentUserID: nil, LeftVal: 1, RightVal: 4, Layer: 1,
  1078. }).Error; err != nil {
  1079. t.Fatalf("建分账根节点失败: %v", err)
  1080. }
  1081. if err := db.Create(&model.UserDivideInto{
  1082. UserID: courseTestRecommender, Type: model.DivideTypePerLesson, Quota: "0.00", TotalIncome: "0.00",
  1083. RootUserID: &root, ParentUserID: &parent, LeftVal: 2, RightVal: 3, Layer: 2,
  1084. }).Error; err != nil {
  1085. t.Fatalf("建推荐人节点失败: %v", err)
  1086. }
  1087. // ⑥ 课酬方案 + 规则(命中:reward=100.00)
  1088. effect := time.Now().AddDate(0, 0, -30)
  1089. scheme := &model.CoursePayment{
  1090. InstitutionID: 1, CampusID: 10, Actived: true, EffectDate: &effect,
  1091. }
  1092. if err := db.Create(scheme).Error; err != nil {
  1093. t.Fatalf("建课酬方案失败: %v", err)
  1094. }
  1095. detail := &model.CoursePaymentDetail{
  1096. CoursePaymentID: scheme.ID, GradeID: -1, SubjectID: -1, ClassType: 1000, ClassifyID: 0,
  1097. Percentage: "0.0", MinPayment: "0.00", MaxPayment: "0.00", Reward: "100.00",
  1098. TeacherCert: false, TeacherExpMin: "0.000", TeacherExpMax: "100.000", Actived: true,
  1099. }
  1100. if err := db.Create(detail).Error; err != nil {
  1101. t.Fatalf("建课酬规则失败: %v", err)
  1102. }
  1103. return &courseFinishFixture{
  1104. Course: course, Record: record, Enroll: enroll,
  1105. DetailID: detail.ID, Recommender: courseTestRecommender, Upline: courseTestUpline,
  1106. }
  1107. }
  1108. // TestFinishRecordCrossTableLinkage 端点 51:**一次调用 = 五张表联动**,逐表断言。
  1109. //
  1110. // 变红矩阵(每条断言对应一种真实错法):
  1111. //
  1112. // ① t_courses_record_student.cost/give_cost/teacher_reward → 漏写打卡行/课酬分摊
  1113. // ② t_user_expense.spend → 漏累加全局统计列
  1114. // ③ t_user_expense_school.spend → 只加了全局、漏了校区
  1115. // ④ t_user_divide_into_log(money=quota)+ total_income → 分账未入账/入错金额
  1116. // ⑤ t_courses_record(status=2 + income + teacher_reward) → 汇总列没落/落错
  1117. // ⑥ t_courses_student(finished_number/remainder_*) → 扣课时没扣
  1118. func TestFinishRecordCrossTableLinkage(t *testing.T) {
  1119. db := newCourseTestDB(t)
  1120. fx := seedFinishFixture(t, db)
  1121. app := newCourseTestApp(t, db)
  1122. code, msg, data := doJSON(t, app, fiber.MethodPost,
  1123. "/admin/courses/records/"+itoa(fx.Record.ID)+"/finish", map[string]any{}, "X-Test-Token", "t")
  1124. if code != 200 {
  1125. t.Fatalf("结束上课 = %d(%s),期望 200", code, msg)
  1126. }
  1127. payload := jsonMap(t, data)
  1128. if got, _ := payload["status"].(float64); got != float64(model.CoursesRecordStatusFinished) {
  1129. t.Fatalf("status = %v,期望 2", payload["status"])
  1130. }
  1131. if changed, _ := payload["changed"].(bool); !changed {
  1132. t.Fatalf("changed = false,期望 true(首次结课必须真的写库)")
  1133. }
  1134. if got, _ := payload["totalSpend"].(string); got != "100.00" {
  1135. t.Fatalf("totalSpend = %v,期望 \"100.00\"", payload["totalSpend"])
  1136. }
  1137. payroll, _ := payload["payroll"].(map[string]any)
  1138. if got, _ := payroll["reward"].(string); got != "100.00" {
  1139. t.Fatalf("payroll.reward = %v,期望 \"100.00\"(方案 reward 列);"+
  1140. "为 0.00 说明课酬端口没接上(quoter=nil)", payroll["reward"])
  1141. }
  1142. if got, _ := payroll["detailId"].(float64); got != float64(fx.DetailID) {
  1143. t.Fatalf("payroll.detailId = %v,期望 %d(命中的课酬规则 ID)", payroll["detailId"], fx.DetailID)
  1144. }
  1145. divide, _ := payload["divide"].([]any)
  1146. if len(divide) != 1 {
  1147. t.Fatalf("divide 条数 = %d,期望 1(推荐人的上级应入账):%s", len(divide), string(data))
  1148. }
  1149. d0, _ := divide[0].(map[string]any)
  1150. if got, _ := d0["amount"].(string); got != "20.00" {
  1151. t.Fatalf("divide[0].amount = %v,期望 \"20.00\"(源列 money)", d0["amount"])
  1152. }
  1153. if got, _ := d0["userId"].(string); got != fx.Upline {
  1154. t.Fatalf("divide[0].userId = %v,期望 %s", d0["userId"], fx.Upline)
  1155. }
  1156. // 裁决后形状 `{userId, type, amount}`:type 必须来自日志行的 `type`(夹具用 type=2 按课次)
  1157. if got, _ := d0["type"].(float64); got != float64(model.DivideTypePerLesson) {
  1158. t.Fatalf("divide[0].type = %v,期望 %d(源列 type = 按课次)", d0["type"], model.DivideTypePerLesson)
  1159. }
  1160. // 防回潮:`level`/`quota` 无对应列,**任何形式的下发都不允许**(包括"填常量让它看起来有值")
  1161. for _, forbidden := range []string{"level", "quota"} {
  1162. if v, has := d0[forbidden]; has {
  1163. t.Fatalf("divide[0] 下发了 %q=%v:该字段在 t_user_divide_into_log 里没有对应列,"+
  1164. "填常量顶替属伪造历史(团队裁决已删)", forbidden, v)
  1165. }
  1166. }
  1167. // ① 打卡行三列
  1168. var att struct {
  1169. Cost string `gorm:"column:cost"`
  1170. GiveCost string `gorm:"column:give_cost"`
  1171. Reward string `gorm:"column:teacher_reward"`
  1172. EndTime *time.Time `gorm:"column:end_time"`
  1173. }
  1174. if err := db.Raw(`SELECT cost, give_cost, teacher_reward, end_time FROM t_courses_record_student
  1175. WHERE record_id = ? AND student_id = ?`, fx.Record.ID, courseTestStudent).Scan(&att).Error; err != nil {
  1176. t.Fatalf("回读打卡行失败: %v", err)
  1177. }
  1178. requireMoney(t, "打卡行 cost", att.Cost, "100.00")
  1179. requireMoney(t, "打卡行 give_cost", att.GiveCost, "0.00")
  1180. requireMoney(t, "打卡行 teacher_reward", att.Reward, "100.00")
  1181. if att.EndTime == nil {
  1182. t.Fatalf("打卡行 end_time 为空:非空才是「已完成」(分成归属判据)")
  1183. }
  1184. // ② 全局账户 spend(**balance 必须不动**)
  1185. var global struct {
  1186. Spend string `gorm:"column:spend"`
  1187. Balance string `gorm:"column:balance"`
  1188. }
  1189. if err := db.Raw("SELECT spend, balance FROM t_user_expense WHERE user_id = ?", courseTestStudent).
  1190. Scan(&global).Error; err != nil {
  1191. t.Fatalf("回读全局账户失败: %v", err)
  1192. }
  1193. requireMoney(t, "t_user_expense.spend", global.Spend, "100.00") // 漏累加统计列
  1194. requireMoney(t, "t_user_expense.balance", global.Balance, "1000.00") // spend 是统计列,**不得动 balance**
  1195. // ③ 校区账户 spend
  1196. var school struct {
  1197. Spend string `gorm:"column:spend"`
  1198. }
  1199. if err := db.Raw("SELECT spend FROM t_user_expense_school WHERE user_id = ? AND campus_id = 10",
  1200. courseTestStudent).Scan(&school).Error; err != nil {
  1201. t.Fatalf("回读校区账户失败: %v", err)
  1202. }
  1203. requireMoney(t, "t_user_expense_school.spend", school.Spend, "100.00") // 只加全局漏了校区
  1204. // ④ 分账明细 + total_income
  1205. var divideRow struct {
  1206. UserID string `gorm:"column:user_id"`
  1207. Money string `gorm:"column:money"`
  1208. OrderNo string `gorm:"column:order_no"`
  1209. }
  1210. if err := db.Raw("SELECT user_id, money, order_no FROM t_user_divide_into_log WHERE student_id = ?",
  1211. courseTestStudent).Scan(&divideRow).Error; err != nil {
  1212. t.Fatalf("回读分账明细失败: %v", err)
  1213. }
  1214. if divideRow.UserID != fx.Upline {
  1215. t.Fatalf("分账明细 user = %s,期望 %s", divideRow.UserID, fx.Upline)
  1216. }
  1217. requireMoney(t, "分账明细 money", divideRow.Money, "20.00")
  1218. if divideRow.OrderNo != itoa(fx.Record.ID) {
  1219. t.Fatalf("分账 order_no = %q,期望上课记录 ID %d(按课次幂等键)", divideRow.OrderNo, fx.Record.ID)
  1220. }
  1221. var upline struct {
  1222. TotalIncome string `gorm:"column:total_income"`
  1223. }
  1224. if err := db.Raw("SELECT total_income FROM t_user_divide_into WHERE user_id = ?", fx.Upline).
  1225. Scan(&upline).Error; err != nil {
  1226. t.Fatalf("回读分账节点失败: %v", err)
  1227. }
  1228. requireMoney(t, "t_user_divide_into.total_income", upline.TotalIncome, "20.00")
  1229. // ⑤ record 汇总列
  1230. var rec struct {
  1231. Status int32 `gorm:"column:status"`
  1232. Income string `gorm:"column:income"`
  1233. TeacherReward string `gorm:"column:teacher_reward"`
  1234. StudentNumber int32 `gorm:"column:student_number"`
  1235. }
  1236. if err := db.Raw("SELECT status, income, teacher_reward, student_number FROM t_courses_record WHERE id = ?",
  1237. fx.Record.ID).Scan(&rec).Error; err != nil {
  1238. t.Fatalf("回读实例失败: %v", err)
  1239. }
  1240. if rec.Status != model.CoursesRecordStatusFinished || rec.StudentNumber != 1 {
  1241. t.Fatalf("record = status %d / students %d,期望 2/1", rec.Status, rec.StudentNumber)
  1242. }
  1243. requireMoney(t, "record.income", rec.Income, "100.00")
  1244. requireMoney(t, "record.teacher_reward", rec.TeacherReward, "100.00")
  1245. // ⑥ 扣课时
  1246. var enrollment struct {
  1247. Finished int32 `gorm:"column:finished_number"`
  1248. Remainder int32 `gorm:"column:remainder_number"`
  1249. RemainderCost string `gorm:"column:remainder_cost"`
  1250. }
  1251. if err := db.Raw(`SELECT finished_number, remainder_number, remainder_cost FROM t_courses_student
  1252. WHERE id = ?`, fx.Enroll.ID).Scan(&enrollment).Error; err != nil {
  1253. t.Fatalf("回读报课行失败: %v", err)
  1254. }
  1255. if enrollment.Finished != 1 || enrollment.Remainder != 9 {
  1256. t.Fatalf("扣课时 = finished %d / remainder %d,期望 1/9", enrollment.Finished, enrollment.Remainder)
  1257. }
  1258. requireMoney(t, "remainder_cost", enrollment.RemainderCost, "900.00")
  1259. // 幂等:再结一次 → changed=false,且分账**不重复入账**
  1260. code, msg, data = doJSON(t, app, fiber.MethodPost,
  1261. "/admin/courses/records/"+itoa(fx.Record.ID)+"/finish", map[string]any{}, "X-Test-Token", "t")
  1262. if code != 200 {
  1263. t.Fatalf("重复结课 = %d(%s),期望 200(幂等成功)", code, msg)
  1264. }
  1265. if changed, _ := jsonMap(t, data)["changed"].(bool); changed {
  1266. t.Fatalf("重复结课 changed = true,期望 false(幂等命中:本次未写任何表)")
  1267. }
  1268. var logCount int64
  1269. db.Model(&model.UserDivideIntoLog{}).Where("student_id = ?", courseTestStudent).Count(&logCount)
  1270. if logCount != 1 {
  1271. t.Fatalf("分账明细条数 = %d,期望 1(重复结课不得重复入账)", logCount)
  1272. }
  1273. }
  1274. // TestFinishRecordPercentageReward 端点 51 的**按比例提成**(D10:端口扩 `Income`/`TeacherExp` 后必须能算)。
  1275. //
  1276. // 三组夹具(各自独立库):
  1277. //
  1278. // A 纯比例:percentage=85.0 / min=max=0 / reward=0,课费 100.00 → 课酬 **85.00**
  1279. // B 下限夹取:同上但 min=90.00 → 课酬 **90.00**(比例算出 85 被抬到下限)
  1280. // C 上限夹取:percentage=200.0 / max=150.00 → 课酬 **150.00**(比例算出 200 被压到上限)
  1281. //
  1282. // 变红条件:
  1283. // - 适配器只返回 `reward` 列(D10 修复前的行为)→ A 得 0.00、B 得 90.00 但 A 红;
  1284. // - 漏掉 min/max 夹取 → B/C 红;
  1285. // - 把 `percentage` 当 0~1 比率(85.0 → 8500%)→ A 得 8500.00,红。
  1286. func TestFinishRecordPercentageReward(t *testing.T) {
  1287. cases := []struct {
  1288. name string
  1289. percentage string
  1290. minPayment string
  1291. maxPayment string
  1292. reward string
  1293. want string
  1294. }{
  1295. {"纯比例 85%", "85.0", "0.00", "0.00", "0.00", "85.00"},
  1296. {"下限抬到 90", "85.0", "90.00", "0.00", "0.00", "90.00"},
  1297. {"上限压到 150", "200.0", "0.00", "150.00", "0.00", "150.00"},
  1298. }
  1299. for _, tc := range cases {
  1300. t.Run(tc.name, func(t *testing.T) {
  1301. db := newCourseTestDB(t)
  1302. fx := seedFinishFixture(t, db)
  1303. // 改写课酬规则:比例型方案(reward 置 0,避免固定额掩盖比例部分)
  1304. if err := db.Model(&model.CoursePaymentDetail{}).Where("id = ?", fx.DetailID).
  1305. Updates(map[string]any{
  1306. "percentage": tc.percentage,
  1307. "min_payment": tc.minPayment,
  1308. "max_payment": tc.maxPayment,
  1309. "reward": tc.reward,
  1310. }).Error; err != nil {
  1311. t.Fatalf("改写课酬规则失败: %v", err)
  1312. }
  1313. app := newCourseTestApp(t, db)
  1314. code, msg, data := doJSON(t, app, fiber.MethodPost,
  1315. "/admin/courses/records/"+itoa(fx.Record.ID)+"/finish", map[string]any{}, "X-Test-Token", "t")
  1316. if code != 200 {
  1317. t.Fatalf("结束上课 = %d(%s),期望 200", code, msg)
  1318. }
  1319. payroll, _ := jsonMap(t, data)["payroll"].(map[string]any)
  1320. if got, _ := payroll["reward"].(string); got != tc.want {
  1321. t.Fatalf("payroll.reward = %v,期望 %s(percentage=%s min=%s max=%s,课收入 100.00)",
  1322. payroll["reward"], tc.want, tc.percentage, tc.minPayment, tc.maxPayment)
  1323. }
  1324. // 落库一致性:record.teacher_reward 与打卡行 teacher_reward 都必须等于该值
  1325. var rec struct {
  1326. TeacherReward string `gorm:"column:teacher_reward"`
  1327. }
  1328. if err := db.Raw("SELECT teacher_reward FROM t_courses_record WHERE id = ?", fx.Record.ID).
  1329. Scan(&rec).Error; err != nil {
  1330. t.Fatalf("回读实例失败: %v", err)
  1331. }
  1332. requireMoney(t, "record.teacher_reward", rec.TeacherReward, tc.want)
  1333. var stu struct {
  1334. TeacherReward string `gorm:"column:teacher_reward"`
  1335. }
  1336. if err := db.Raw(`SELECT teacher_reward FROM t_courses_record_student
  1337. WHERE record_id = ? AND student_id = ?`, fx.Record.ID, courseTestStudent).Scan(&stu).Error; err != nil {
  1338. t.Fatalf("回读打卡行失败: %v", err)
  1339. }
  1340. requireMoney(t, "打卡行 teacher_reward", stu.TeacherReward, tc.want)
  1341. })
  1342. }
  1343. }
  1344. // TestFinishRecordRollsBackWhenDivideFails 端点 51 的**回滚变异**:让第 3 步(分账)失败,
  1345. // 断言前两步(扣课时 / spend / 打卡行)**全部回滚**。
  1346. //
  1347. // 手法:请求前 `DROP TABLE t_user_divide_into_log` ⇒ 结课事务内 INSERT 分账明细必然失败。
  1348. // 为什么不用"注入错误":handler 层测试无法替换内部服务(`servicesFor` 现场构造),
  1349. // 而 DROP 表是**真实基础设施故障**的同构复现(表不存在 = SQL 报错 = 事务回滚)。
  1350. //
  1351. // 变红条件:把分账放到事务外(或吞掉错误)→ 断言 1 变红(接口返回 200),断言 2~5 变红(数据已落库)。
  1352. func TestFinishRecordRollsBackWhenDivideFails(t *testing.T) {
  1353. db := newCourseTestDB(t)
  1354. fx := seedFinishFixture(t, db)
  1355. if err := db.Exec("DROP TABLE t_user_divide_into_log").Error; err != nil {
  1356. t.Fatalf("删分账明细表失败: %v", err)
  1357. }
  1358. app := newCourseTestApp(t, db)
  1359. code, msg, _ := doJSON(t, app, fiber.MethodPost,
  1360. "/admin/courses/records/"+itoa(fx.Record.ID)+"/finish", map[string]any{}, "X-Test-Token", "t")
  1361. // 断言 1:分账失败必须让整个请求失败,且**必须是数据库级失败**。
  1362. //
  1363. // 为什么钉死成 5002:夹具数据全部合法(实例存在且上课中、有在读学生、有课酬方案),
  1364. // 唯一缺失的是分账明细表 ⇒ 能导致失败的只可能是第 ④ 步的 INSERT。
  1365. // 若这里变成 2001/3121/3001,说明失败发生在第 ④ 步**之前**,该用例就退化成"空断言"。
  1366. if code == 200 {
  1367. t.Fatalf("分账失败时结课仍返回 200(%s):分账没在结课事务内", msg)
  1368. }
  1369. if code != infraerrors.ErrDBError.Code {
  1370. t.Fatalf("失败码 = %d(%s),期望 5002(数据库异常)——"+
  1371. "若不是 5002,说明失败发生在前几步,回滚断言会变成空断言", code, msg)
  1372. }
  1373. // 断言 2:报课行扣课时**必须回滚**
  1374. var enrollment struct {
  1375. Finished int32 `gorm:"column:finished_number"`
  1376. Remainder int32 `gorm:"column:remainder_number"`
  1377. RemainderCost string `gorm:"column:remainder_cost"`
  1378. }
  1379. if err := db.Raw(`SELECT finished_number, remainder_number, remainder_cost FROM t_courses_student
  1380. WHERE id = ?`, fx.Enroll.ID).Scan(&enrollment).Error; err != nil {
  1381. t.Fatalf("回读报课行失败: %v", err)
  1382. }
  1383. if enrollment.Finished != 0 || enrollment.Remainder != 10 {
  1384. t.Fatalf("扣课时未回滚:finished %d / remainder %d,期望 0/10",
  1385. enrollment.Finished, enrollment.Remainder)
  1386. }
  1387. requireMoney(t, "remainder_cost(回滚后)", enrollment.RemainderCost, "1000.00")
  1388. // 断言 3 / 4:两个账户的 spend 必须回滚
  1389. var global struct {
  1390. Spend string `gorm:"column:spend"`
  1391. }
  1392. db.Raw("SELECT spend FROM t_user_expense WHERE user_id = ?", courseTestStudent).Scan(&global)
  1393. requireMoney(t, "t_user_expense.spend(回滚后)", global.Spend, "0.00")
  1394. var school struct {
  1395. Spend string `gorm:"column:spend"`
  1396. }
  1397. db.Raw("SELECT spend FROM t_user_expense_school WHERE user_id = ? AND campus_id = 10", courseTestStudent).Scan(&school)
  1398. requireMoney(t, "t_user_expense_school.spend(回滚后)", school.Spend, "0.00")
  1399. // 断言 5:打卡行不得留下 cost>0 的痕迹
  1400. var att struct {
  1401. Cost string `gorm:"column:cost"`
  1402. }
  1403. db.Raw(`SELECT cost FROM t_courses_record_student WHERE record_id = ? AND student_id = ?`,
  1404. fx.Record.ID, courseTestStudent).Scan(&att)
  1405. if strings.TrimSpace(att.Cost) != "" {
  1406. amount, perr := money.Parse(att.Cost)
  1407. if perr != nil || amount.Cents() != 0 {
  1408. t.Fatalf("打卡行 cost = %q,期望无行或 0.00(未随失败回滚)", att.Cost)
  1409. }
  1410. }
  1411. // 断言 6:实例状态不得变成已结束
  1412. var rec struct {
  1413. Status int32 `gorm:"column:status"`
  1414. }
  1415. db.Raw("SELECT status FROM t_courses_record WHERE id = ?", fx.Record.ID).Scan(&rec)
  1416. if rec.Status == model.CoursesRecordStatusFinished {
  1417. t.Fatalf("实例 status = 2,期望仍为 1(未随失败回滚)")
  1418. }
  1419. }
  1420. // ---------------------------------------------------------------- 作用域 / 鉴权冒烟
  1421. // TestCourseEndpointsRequireScope 15 条课程端点全部要求作用域(无 scope → 1001)。
  1422. //
  1423. // 这条防的是"某条端点漏挂 mustScope"(无作用域时 Scoped 会 panic → 5001,
  1424. // 而 5001 看起来像"服务故障",会让人去查 DB 而不是查中间件链)。
  1425. func TestCourseEndpointsRequireScope(t *testing.T) {
  1426. db := newCourseTestDB(t)
  1427. app := newCourseTestApp(t, db)
  1428. cases := []struct {
  1429. method string
  1430. path string
  1431. }{
  1432. {fiber.MethodGet, PathCourses},
  1433. {fiber.MethodPost, PathCourses},
  1434. {fiber.MethodPut, "/admin/courses/1"},
  1435. {fiber.MethodGet, "/admin/courses/1/classes"},
  1436. {fiber.MethodPost, "/admin/courses/1/classes"},
  1437. {fiber.MethodGet, "/admin/courses/1/records"},
  1438. {fiber.MethodPost, "/admin/courses/1/records/generate"},
  1439. {fiber.MethodPost, "/admin/courses/records/1/start"},
  1440. {fiber.MethodPost, "/admin/courses/records/1/finish"},
  1441. {fiber.MethodPost, "/admin/courses/records/1/attendance"},
  1442. {fiber.MethodGet, "/admin/courses/1/students"},
  1443. {fiber.MethodPost, "/admin/courses/1/students"},
  1444. {fiber.MethodGet, PathCourseArrears},
  1445. {fiber.MethodPost, PathCourseArrearsCounteract},
  1446. {fiber.MethodGet, PathStudentSchedule},
  1447. }
  1448. for _, tc := range cases {
  1449. code, msg, _ := doJSON(t, app, tc.method, tc.path, nil, "X-Test-Token", "t", "X-Test-Scope", "none")
  1450. if code != infraerrors.ErrUnauth.Code {
  1451. t.Errorf("%s %s 无作用域时 code = %d(%s),期望 1001", tc.method, tc.path, code, msg)
  1452. }
  1453. }
  1454. }